From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCLyw-0003UG-Jd for qemu-devel@nongnu.org; Sun, 03 Mar 2013 22:22:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCLyv-0004T7-FW for qemu-devel@nongnu.org; Sun, 03 Mar 2013 22:22:30 -0500 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:37789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCLyu-0004Sq-VI for qemu-devel@nongnu.org; Sun, 03 Mar 2013 22:22:29 -0500 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 4 Mar 2013 13:14:51 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 0A9672BB0053 for ; Mon, 4 Mar 2013 14:22:21 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2439bPH63111264 for ; Mon, 4 Mar 2013 14:09:38 +1100 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r243MJOi025188 for ; Mon, 4 Mar 2013 14:22:19 +1100 Message-ID: <51341311.4000407@linux.vnet.ibm.com> Date: Mon, 04 Mar 2013 11:20:49 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1361875228-15769-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1361875228-15769-10-git-send-email-xiawenc@linux.vnet.ibm.com> <874ngxhhfv.fsf@blackfin.pond.sub.org> <20130227162229.GJ2514@dhcp-200-207.str.redhat.com> <513009B9.4090406@linux.vnet.ibm.com> In-Reply-To: <513009B9.4090406@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V7 09/14] block: move bdrv_snapshot_find() to block.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , aliguori@us.ibm.com, Markus Armbruster , qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com 于 2013-3-1 9:51, Wenchao Xia 写道: > 于 2013-2-28 0:22, Kevin Wolf 写道: >> Am 27.02.2013 um 17:04 hat Markus Armbruster geschrieben: >>> Wenchao Xia writes: >>> >>>> Signed-off-by: Wenchao Xia >>>> Reviewed-by: Eric Blake >>>> --- >>>> block.c | 24 ++++++++++++++++++++++++ >>>> include/block/block.h | 2 ++ >>>> savevm.c | 22 ---------------------- >>>> 3 files changed, 26 insertions(+), 22 deletions(-) >>> >>> Perhaps savevm.c isn't the best home for snapshot stuff, but I don't >>> like it in block.c any better. block.c is already unwieldy, and I'd >>> like us to try limiting it to core block stuff. >>> >>> Kevin, Stefan, any ideas? >> >> Take some more snapshot related functions from block.c and move them to >> block/snapshot.c? >> >> Kevin >> > Hi, Stefan > Do you also agree about adding new file block/snapshot.c? > > Hi, I am going to add include/block/snapshot.h and block/snapshot.c, all internal snapshot function in block.c will be moved there. external backing file related function will not be touched and remain in block.c. This consume many effort and once done it will be hard to revert back to form an incremental commit in this serials, so before coding, please give your opinion if u don't agree about it. -- Best Regards Wenchao Xia