From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43827)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UCSWa-00069g-7p
	for qemu-devel@nongnu.org; Mon, 04 Mar 2013 05:21:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UCSWZ-0001Mr-8D
	for qemu-devel@nongnu.org; Mon, 04 Mar 2013 05:21:40 -0500
Received: from mx1.redhat.com ([209.132.183.28]:5535)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UCSWY-0001Mh-VK
	for qemu-devel@nongnu.org; Mon, 04 Mar 2013 05:21:39 -0500
Message-ID: <51347597.8070406@redhat.com>
Date: Mon, 04 Mar 2013 11:21:11 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1362051581.git.hutao@cn.fujitsu.com>
	<d7b92bed37f3669194b45acd8736b4b7ac71cc95.1362051582.git.hutao@cn.fujitsu.com>
	<5134730A.2050406@de.ibm.com>
In-Reply-To: <5134730A.2050406@de.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v13 6/8] introduce a new qom device to deal
 with panicked event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Gleb Natapov <gleb@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Hu Tao <hutao@cn.fujitsu.com>, qemu-devel <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Orit Wasserman <owasserm@redhat.com>, kvm list <kvm@vger.kernel.org>, Juan Quintela <quintela@redhat.com>, Markus Armbruster <armbru@redhat.com>, Jens Freimann <jfrei@linux.vnet.ibm.com>, Jan Kiszka <jan.kiszka@siemens.com>, Andrew Jones <drjones@redhat.com>, Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>, Alex Williamson <alex.williamson@redhat.com>, Sasha Levin <levinsasha928@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Kevin Wolf <kwolf@redhat.com>, Alexander Graf <agraf@suse.de>, Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Einar Lueck <elelueck@linux.vnet.ibm.com>

Il 04/03/2013 11:10, Christian Borntraeger ha scritto:
> +            //disabled wait: we either
> +            //do a
> +            //monitor_protocol_event(QEVENT_GUEST_PANICKED, whatever);
> +            //or
> +            //or call into pvevent
>              r = EXCP_HALTED;
>              break;
>          case ICPT_CPU_STOP:
> 
> 
> I would prefer to just use the monitor_protocol_event, on the other hand
> a call into pvent could make it configurable.

I asked in my review to make pvevent not configurable,  So

   monitor_protocol_event(QEVENT_GUEST_PANICKED);
   vm_stop(RUNSTATE_GUEST_PANICKED);

would do I guess.

Feel free to submit a patch to qemu-devel.  Hu, please take any patch
that Christian submits and incorporate it in your series for future posting.

Paolo