From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCSd7-0001CP-H6 for qemu-devel@nongnu.org; Mon, 04 Mar 2013 05:28:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCSd6-0003H0-Dg for qemu-devel@nongnu.org; Mon, 04 Mar 2013 05:28:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCSd6-0003Gs-44 for qemu-devel@nongnu.org; Mon, 04 Mar 2013 05:28:24 -0500 Message-ID: <51347735.9090204@redhat.com> Date: Mon, 04 Mar 2013 11:28:05 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20130303091738.GB23616@redhat.com> <513471F1.5020702@redhat.com> <20130304102131.GK23616@redhat.com> In-Reply-To: <20130304102131.GK23616@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v13 0/8] pv event interface between host and guest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: Peter Maydell , kvm list , "Michael S. Tsirkin" , Hu Tao , qemu-devel , Markus Armbruster , Blue Swirl , Orit Wasserman , Juan Quintela , Alexander Graf , Jan Kiszka , Andrew Jones , Alex Williamson , Sasha Levin , Stefan Hajnoczi , Luiz Capitulino , KAMEZAWA Hiroyuki , Kevin Wolf , Anthony Liguori , Marcelo Tosatti , "linux-kernel@vger.kernel.org" Il 04/03/2013 11:21, Gleb Natapov ha scritto: >> > Just to clarify it for Hu Tao, the read from a random ioport is how the >> > ACPI code will detect presence of the device. >> > > Actually no (at least in the long run, for the first version it may be > OK). Agreed. > Since we want to move DSDT generation into QEMU if device will not > be present QEMU will not generate corresponded Device() in DSDT, or it > will generate it with _STA() { Return (0x00)} hard coded. Yes, this would be good. > Seabios can do > the same if we will pass it info about device presence via fw_cfg. True, but I don't like this a lot. I don't like splitting decisions between SeaBIOS and the DSDT, you end up touching code all over the place and writing ASL is simpler than patching---even with all the machinery that we have. It is also simpler to move ASL from SeaBIOS to OVMF and/or viceversa. I don't recall what was the opposition to a fw_cfg driver directly in the DSDT, but I think this would be a good usage for it. Splitting it between QEMU and DSDT is a bit better, since you have to touch QEMU anyway to implement the feature. Anyhow, this does not apply to the next submission of this series. I think we can agree to the compromise of using ACPI but still read the port in _STA. Paolo