From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59679)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UCTYF-0008He-Jq
	for qemu-devel@nongnu.org; Mon, 04 Mar 2013 06:27:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UCTYD-0003cd-4y
	for qemu-devel@nongnu.org; Mon, 04 Mar 2013 06:27:27 -0500
Received: from cantor2.suse.de ([195.135.220.15]:39452 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UCTYC-0003cR-V4
	for qemu-devel@nongnu.org; Mon, 04 Mar 2013 06:27:25 -0500
Message-ID: <5134851A.8060700@suse.de>
Date: Mon, 04 Mar 2013 12:27:22 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1362237527-23678-1-git-send-email-sanjayl@kymasys.com>
	<1362237527-23678-10-git-send-email-sanjayl@kymasys.com>
In-Reply-To: <1362237527-23678-10-git-send-email-sanjayl@kymasys.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 08/12] KVM/MIPS: Enable KVM/MIPS for MIPS
 targets. Add MIPS GIC code to the build.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sanjay Lal <sanjayl@kymasys.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>, kvm@vger.kernel.org

Am 02.03.2013 16:18, schrieb Sanjay Lal:
> ---
>  configure                 | 17 +++++++++++++++--
>  hw/mips/Makefile.objs     |  2 +-
>  target-mips/Makefile.objs |  1 +
>  3 files changed, 17 insertions(+), 3 deletions(-)
>=20
> diff --git a/configure b/configure
> index bf5970f..5447661 100755
> --- a/configure
> +++ b/configure
> @@ -1370,7 +1370,12 @@ case "$cpu" in
>        bigendian=3Dyes
>      fi
>    ;;
> -  hppa|m68k|mips|mips64|ppc|ppc64|s390|s390x|sparc|sparc64)
> +  mips|mips64)
> +    if check_define __MIPSEB__; then
> +      bigendian=3Dyes
> +    fi
> +  ;;
> +  hppa|m68k|ppc|ppc64|s390|s390x|sparc|sparc64)
>      bigendian=3Dyes
>    ;;
>  esac
[snip]

If this is needed it should be a patch on its own. But we already
support mipsel I thought, so I don't understand why the change is needed
without proper commit message.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg