From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: kvm@vger.kernel.org, Gleb Natapov <gleb@redhat.com>,
patches@linaro.org, Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvmarm@lists.cs.columbia.edu
Subject: Re: [Qemu-devel] [PATCH v7 07/11] hw/arm_gic: Convert ARM GIC classes to use init/realize
Date: Mon, 04 Mar 2013 13:04:47 +0100 [thread overview]
Message-ID: <51348DDF.6090604@suse.de> (raw)
In-Reply-To: <CAFEAcA9ehuSRtA2aYvXTyCYA4VFv5T8zRLq4NyNCzXGSbCya-g@mail.gmail.com>
Am 04.03.2013 12:50, schrieb Peter Maydell:
> On 4 March 2013 19:10, Andreas Färber <afaerber@suse.de> wrote:
>> Am 26.02.2013 18:40, schrieb Peter Maydell:
>
>>> if (s->num_cpu > NCPU) {
>>> - hw_error("requested %u CPUs exceeds GIC maximum %d\n",
>>> - s->num_cpu, NCPU);
>>> + error_setg(errp, "requested %u CPUs exceeds GIC maximum %d\n",
>>
>> Please drop \n for error_setg(). Probably would be worth adding to a
>> convert-to-realize section on the Wiki.
>
> Doh. That's such a trivial change I intend to just make it in
> passing when I put these changes into target-arm.next rather
> than sending out an entire fresh round of patches, unless you
> object.
>
>> Otherwise looks fine, thanks.
>
> Should I mark such a fixed-up patch with your reviewed-by tag?
Yes, that's fine, thanks.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-03-04 12:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1361900421-28354-1-git-send-email-peter.maydell@linaro.org>
[not found] ` <1361900421-28354-10-git-send-email-peter.maydell@linaro.org>
2013-03-04 11:06 ` [Qemu-devel] [PATCH v7 09/11] hw/kvm/arm_gic: Implement support for KVM in-kernel ARM GIC Andreas Färber
[not found] ` <1361900421-28354-8-git-send-email-peter.maydell@linaro.org>
2013-03-04 11:10 ` [Qemu-devel] [PATCH v7 07/11] hw/arm_gic: Convert ARM GIC classes to use init/realize Andreas Färber
2013-03-04 11:50 ` Peter Maydell
2013-03-04 12:04 ` Andreas Färber [this message]
[not found] ` <1361900421-28354-4-git-send-email-peter.maydell@linaro.org>
2013-03-04 11:12 ` [Qemu-devel] [PATCH v7 03/11] target-arm: Drop CPUARMState* argument from bank_number() Andreas Färber
2013-03-06 19:36 ` [Qemu-devel] [PATCH v7 00/11] QEMU: Support KVM on ARM Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51348DDF.6090604@suse.de \
--to=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=mtosatti@redhat.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).