From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCalI-0001vN-LF for qemu-devel@nongnu.org; Mon, 04 Mar 2013 14:09:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCalE-0005oe-DQ for qemu-devel@nongnu.org; Mon, 04 Mar 2013 14:09:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59549) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCalE-0005oX-4F for qemu-devel@nongnu.org; Mon, 04 Mar 2013 14:09:20 -0500 Message-ID: <5134EFDC.5000107@redhat.com> Date: Mon, 04 Mar 2013 12:02:52 -0700 From: Eric Blake MIME-Version: 1.0 References: <1362388590-13010-1-git-send-email-lilei@linux.vnet.ibm.com> <1362388590-13010-2-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1362388590-13010-2-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2XGAFLGCROCBJSLDCDOCX" Subject: Re: [Qemu-devel] [PATCH 1/2] qga: add guest-get-time command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2XGAFLGCROCBJSLDCDOCX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/04/2013 02:16 AM, Lei Li wrote: > Signed-off-by: Lei Li > --- > qga/commands-posix.c | 16 ++++++++++++++++ > qga/qapi-schema.json | 13 +++++++++++++ > 2 files changed, 29 insertions(+) >=20 > ## > +# @guest-get-time: > +# > +# Get the information about guest time relative to the Epoch > +# of 1970-01-01 in UTC. > +# > +# Returns: Time in nanoseconds on success. The return value is only possible on success in the first place, so you can simplify this: s/ on success// But that's minor, and I'm okay even with the longer wording, so: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2XGAFLGCROCBJSLDCDOCX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRNO/cAAoJEKeha0olJ0NqdyIH/2Nag7nJdyhUfUKuNB4zLtS5 hjLkiVe6j+UdkxwvwUd0GU/vwVy8X9gcPInVu/rSc4DzSPdVDW6+wRnjfJd+4EzY 0GCuK6yidG9wBLkYf0PeQD7fhwPe3XoqKzSW587I9fshbtRlzQRFONtGekYyuGhz ridXx+ffNNuhO7Rrwjm2iENCaA6FqfpQ6cwNtuqCUKhe2h4gpfhgQy7qq+iZzBSD VC3o9W7kmIFj22m1UsqSWJgTDDzkRrt9iqabR5GfoCWwBePAAKdUdll44omt1FTW c7vdLB4nECcQcT/2IFD+f53j+KGestU0CGtH4H9GFb69wOS7PqZlg97JTTBa7fY= =mOJR -----END PGP SIGNATURE----- ------enig2XGAFLGCROCBJSLDCDOCX--