From: Eric Blake <eblake@redhat.com>
To: mdroth <mdroth@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, Lei Li <lilei@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command
Date: Mon, 04 Mar 2013 12:03:42 -0700 [thread overview]
Message-ID: <5134F00E.5080407@redhat.com> (raw)
In-Reply-To: <20130304181605.GD21850@vm>
[-- Attachment #1: Type: text/plain, Size: 736 bytes --]
On 03/04/2013 11:16 AM, mdroth wrote:
> On Mon, Mar 04, 2013 at 05:16:30PM +0800, Lei Li wrote:
>> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
>> ---
>> qga/commands-posix.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>> qga/qapi-schema.json | 27 ++++++++++++++++++++++++++
>> 2 files changed, 81 insertions(+)
>>
>> +# @time: time of nanoseconds, relative to the Epoch of
>
> "time in nanoseconds", but I can fix this up myself if there are no
> other comments that need to be addressed.
Unfortunately, that's not the only problem, and I think a v5 is
warranted (see my other mail).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-03-04 19:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 9:16 [Qemu-devel] [PATCH 0/2 v4] Time resync support by qemu-ga Lei Li
2013-03-04 9:16 ` [Qemu-devel] [PATCH 1/2] qga: add guest-get-time command Lei Li
2013-03-04 18:04 ` mdroth
2013-03-04 19:02 ` Eric Blake
2013-03-04 9:16 ` [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command Lei Li
2013-03-04 18:16 ` mdroth
2013-03-04 19:03 ` Eric Blake [this message]
2013-03-04 19:01 ` Eric Blake
-- strict thread matches above, loose matches on Subject: below --
2013-03-05 9:39 [Qemu-devel] [PATCH 0/2 v5] Time resync support by qemu-ga Lei Li
2013-03-05 9:39 ` [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command Lei Li
2013-03-01 9:32 [Qemu-devel] [PATCH 0/2 v3] Time resync support by qemu-ga Lei Li
2013-03-01 9:33 ` [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command Lei Li
2013-03-01 17:38 ` Eric Blake
2013-03-01 17:50 ` Eric Blake
2013-03-04 8:25 ` Lei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5134F00E.5080407@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=lilei@linux.vnet.ibm.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).