From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCahZ-0007NL-5D for qemu-devel@nongnu.org; Mon, 04 Mar 2013 14:05:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCahT-00051a-Sz for qemu-devel@nongnu.org; Mon, 04 Mar 2013 14:05:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14698) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCahT-00051K-J3 for qemu-devel@nongnu.org; Mon, 04 Mar 2013 14:05:27 -0500 Message-ID: <5134F00E.5080407@redhat.com> Date: Mon, 04 Mar 2013 12:03:42 -0700 From: Eric Blake MIME-Version: 1.0 References: <1362388590-13010-1-git-send-email-lilei@linux.vnet.ibm.com> <1362388590-13010-3-git-send-email-lilei@linux.vnet.ibm.com> <20130304181605.GD21850@vm> In-Reply-To: <20130304181605.GD21850@vm> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2MLGMBCHDNBXWNMPOBPUA" Subject: Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mdroth Cc: aliguori@us.ibm.com, Lei Li , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2MLGMBCHDNBXWNMPOBPUA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/04/2013 11:16 AM, mdroth wrote: > On Mon, Mar 04, 2013 at 05:16:30PM +0800, Lei Li wrote: >> Signed-off-by: Lei Li >> --- >> qga/commands-posix.c | 54 +++++++++++++++++++++++++++++++++++++++++++= +++++++++ >> qga/qapi-schema.json | 27 ++++++++++++++++++++++++++ >> 2 files changed, 81 insertions(+) >> >> +# @time: time of nanoseconds, relative to the Epoch of >=20 > "time in nanoseconds", but I can fix this up myself if there are no > other comments that need to be addressed. Unfortunately, that's not the only problem, and I think a v5 is warranted (see my other mail). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2MLGMBCHDNBXWNMPOBPUA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRNPAOAAoJEKeha0olJ0NqpqcIAJHSxkoFjj5g0d6xai26eqXH PSGUJPSF/d+erj7/a7PeDoqjCHSQ1Z18LXzvK2q+lroH5diEYfJNZ+xsWmEO3Zux uAK+C6EUs01xk5pwJkreSxkB4vuqKwARc8EQHN5RR/Y8qGTQqnmuHXf50nCvQMiC 8DoproAhsVE44am5hKoBIPpapZJBqICCfXgGfI16dMehdMqNN1UK8gd5vLfz8fIw ZrfkGdkUKZQySTKQum7EUY1bluXPisyAKhnfd7rC28eyqe3iWjLVPO8ZgrJ9FCc+ Srk2xUnI1TIz2AJdcdbG1cnvkxVYvZhtZIxKZjgWrc3OyoFKtiIz94VG/F7W0TI= =/69Y -----END PGP SIGNATURE----- ------enig2MLGMBCHDNBXWNMPOBPUA--