From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCdNp-0001jo-CD for qemu-devel@nongnu.org; Mon, 04 Mar 2013 16:57:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCdNn-0001C0-9S for qemu-devel@nongnu.org; Mon, 04 Mar 2013 16:57:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24842) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCdNn-0001Bk-16 for qemu-devel@nongnu.org; Mon, 04 Mar 2013 16:57:19 -0500 Message-ID: <513518B9.5000400@redhat.com> Date: Mon, 04 Mar 2013 14:57:13 -0700 From: Eric Blake MIME-Version: 1.0 References: <512FF819.7050505@redhat.com> <87k3pqzy2y.fsf@codemonkey.ws> <513110D3.5030503@linux.vnet.ibm.com> <87d2vig75m.fsf@codemonkey.ws> <51311A13.6030205@redhat.com> <87r4jy90wt.fsf@codemonkey.ws> <51313660.5010001@redhat.com> <87vc9apt7r.fsf@codemonkey.ws> <513147E4.5030005@redhat.com> <87txouv6hp.fsf@codemonkey.ws> <5131EF32.5010808@redhat.com> <874ngs9ou2.fsf@codemonkey.ws> In-Reply-To: <874ngs9ou2.fsf@codemonkey.ws> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2EGOOACOETUIVFNDKJUPX" Subject: Re: [Qemu-devel] virtio-rng and fd passing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: "libvir-list@redhat.com" , Paolo Bonzini , "qemu-devel@nongnu.org" , Stefan Berger This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2EGOOACOETUIVFNDKJUPX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable [adding libvirt] On 03/03/2013 02:05 PM, Anthony Liguori wrote: > Paolo Bonzini writes: >=20 >> Il 02/03/2013 04:13, Anthony Liguori ha scritto: >>> There is no valid use-case of rng-random other than using /dev/random= =2E >>> In fact, it was probably a mistake to even allow a filename to be >>> specified because it lets people do silly things (like /dev/urandom).= >>> >>> If you want anything other than /dev/random, you should use rng-egd. >> >> /dev/hwrng makes sense too. >=20 > Good point. Perhaps we should issue a warning when anything is used > other than /dev/random or /dev/hwrng to discourage people from doing th= e > wrong thing. I completely understand the confusion and I think we > should try a bit harder to prevent people from getting it wrong. Then libvirt should also make sure that the XML we allow for non-egd virtio-rng is restricted to the two filenames that won't cause a qemu warning, or even modify the XML to not expose a filename in the first place. We haven't released libvirt 1.0.3 yet, so we still have a few hours in which such a change could be made before the XML becomes baked by a release. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2EGOOACOETUIVFNDKJUPX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRNRi5AAoJEKeha0olJ0NqlFEH/RY4j9hWqwspQwCKCM/52L9Q OLOCvVKtStabaRlNTVmCpslGx88HTAbJ9oSlT6t89jar5tJPrtdfC0USBcAFE28a i8uU4l4hnM75Hco8F7EnjYWQM7OgGsHY15DvyQQBBXEBm+rB7FMHVMDOOqFSTRV9 Q9Safdsn1UTnChoYDoVcphpi3epibElP0uuUjIua4nwTwYcuDE5HtZtGkxPge2cN ghUoD9KiZ2QsaK7L7f/XZ8m1W6NlhIs85eqCqatNUsFtcZbu+C42LU/jIsemV75/ P/0B8oMGKHCKYRd2dVhUQVWTmnivqz88pAzRFmJb+dUoAA8wTxCUsJSjVaNz4FI= =6OFe -----END PGP SIGNATURE----- ------enig2EGOOACOETUIVFNDKJUPX--