From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCg1F-0001PG-7h for qemu-devel@nongnu.org; Mon, 04 Mar 2013 19:46:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCg1D-0007hi-R4 for qemu-devel@nongnu.org; Mon, 04 Mar 2013 19:46:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCg1D-0007he-Hu for qemu-devel@nongnu.org; Mon, 04 Mar 2013 19:46:11 -0500 Message-ID: <51353FC2.9030102@redhat.com> Date: Mon, 04 Mar 2013 17:43:46 -0700 From: Eric Blake MIME-Version: 1.0 References: <1361875228-15769-1-git-send-email-xiawenc@linux.vnet.ibm.com> <20130228155702.GJ18389@stefanha-thinkpad.redhat.com> <513008B1.8080605@linux.vnet.ibm.com> <20130304131010.GC18476@stefanha-thinkpad.redhat.com> In-Reply-To: <20130304131010.GC18476@stefanha-thinkpad.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2OVWEEVNXJNTUHQECJCWC" Subject: Re: [Qemu-devel] [PATCH V7 00/14] add qmp/hmp interfaces for internal snapshot info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, aliguori@us.ibm.com, armbru@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, lcapitulino@redhat.com, Wenchao Xia This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2OVWEEVNXJNTUHQECJCWC Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/04/2013 06:10 AM, Stefan Hajnoczi wrote: >>> It is also useful to include QMP examples or the QMP docs in the cove= r >>> letter so reviewers know what you are trying to achieve. >>> >> OK, a better explaination would be added in the cover-letter. >=20 > Thanks. When reviewers don't know your goal at the start of their > review, they may object to things that make sense at the end of the > series because they do not have enough context yet. A series where the= > goal is unclear also risks a higher number of review-fix cycles because= > the reviewers haven't bought into the idea yet. >=20 > It is in everyone's interest to explain the goal in the cover letter. > Then the patches get reviewed more smoothly and merged faster. This is good advice - so good that I added it to the wiki: http://wiki.qemu.org/Contribute/SubmitAPatch >=20 > This is a general thought I wanted to share and I struggle with it > myself sometimes when I submit patch series. Me too - but the nice thing about open source is that we can all learn best practices from one another and become better at it :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2OVWEEVNXJNTUHQECJCWC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRNT/CAAoJEKeha0olJ0NqViMIAJ6jYjvhYTBKpJ3eH029Sk7e F++/nudWKRyiT2bagDHZh5kkIJtG7kSHAsmaYxYO2PTq62FE9MysrHGCJyTqYT89 EhOU30otxiYkHZq4XiCsx/DYS5pcaleOT7tt+SSYbeM4V/z80KlYvwZCo4F0amBh oU3Yn5300st8LfxvJZVRMwU15CizWEsnqtdFlFoHoHnq1Jsvqo343eeJh5FWv2IZ 5WyuLqeEkmQ7DrbBocHeemyFvKJIUGQqx/ic2ne2ajY86zFMEoZtog2mmNve+dUm 91pRSXDI4kKY9mh/zVBRJCjZf3auERNZxR8i16xPgfpVV+8IxODz+0rXVp09Rp0= =eB1a -----END PGP SIGNATURE----- ------enig2OVWEEVNXJNTUHQECJCWC--