From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCg1z-0002cE-N5 for qemu-devel@nongnu.org; Mon, 04 Mar 2013 19:47:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCg1y-0007mZ-DZ for qemu-devel@nongnu.org; Mon, 04 Mar 2013 19:46:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCg1y-0007mV-4Y for qemu-devel@nongnu.org; Mon, 04 Mar 2013 19:46:58 -0500 Message-ID: <5135407F.5000508@redhat.com> Date: Mon, 04 Mar 2013 17:46:55 -0700 From: Eric Blake MIME-Version: 1.0 References: <1362437363-27570-1-git-send-email-eblake@redhat.com> <87sj4ayc6w.fsf@codemonkey.ws> In-Reply-To: <87sj4ayc6w.fsf@codemonkey.ws> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2AWBIBDEDALVSQLRDVWXE" Subject: Re: [Qemu-devel] [PATCH] rng: restrict passthrough names to known-good files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: libvir-list@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2AWBIBDEDALVSQLRDVWXE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/04/2013 04:31 PM, Anthony Liguori wrote: > Eric Blake writes: >=20 >> There is some controversy[1] on the qemu list on whether qemu should >> have ever allowed arbitrary file name passthrough, or whether it >> should be restricted to JUST /dev/random and /dev/hwrng. It is >> always easier to add support for additional filenames than it is >> to remove support for something once released, so this patch >> restricts libvirt 1.0.3 (where the virtio-random backend was first >> supported) to just the two uncontroversial names, letting us defer >> to a later date any decision on whether supporting arbitrary files >> makes sense. Additionally, since qemu 1.4 does NOT support >> /dev/fdset/nnn fd passthrough for the backend, limiting to just >> two known names means that we don't get tempted to try fd >> passthrough where it won't work. >=20 > Acked-by: Anthony Liguori >=20 Thanks; I've pushed this into libvirt. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2AWBIBDEDALVSQLRDVWXE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRNUB/AAoJEKeha0olJ0NqWLYH/RkhW89f7b6u7yW6UduErij7 V3nQE+DNDtpXYfePb3PJAHzdrSFwJUvGORzM529hKHm4W4K2kS/woSO2PwHYz3x0 G5QXwRXzgkX5cdNRrGvNBVkZ9hKvc9EgKK6DGCbWzdFkiMyrLXGS1BuI8FVIVAS8 w12KpGfREAUBpy4REojPajGAAxGDBW3rLmjV7VxvZa85iIPDVuYtjeH1/07+uDVf 1/2tYGGjzT6NxCyKNn5GghOqchE2a3bY79U6AEqDnl8IqWeiclgOc5LKJJcDzmP2 CEgMK+EndHeJMZd979tRQD4pl96IAAPLG9yspbF6dE/9jpVzmd2B1bDarMhoZdw= =zD2Y -----END PGP SIGNATURE----- ------enig2AWBIBDEDALVSQLRDVWXE--