From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCm4V-0002k9-9Z for qemu-devel@nongnu.org; Tue, 05 Mar 2013 02:14:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCm4U-0000Ls-AL for qemu-devel@nongnu.org; Tue, 05 Mar 2013 02:13:59 -0500 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:43945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCm4T-0000IP-Lc for qemu-devel@nongnu.org; Tue, 05 Mar 2013 02:13:58 -0500 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 5 Mar 2013 17:08:50 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id B3D252CE804C for ; Tue, 5 Mar 2013 18:13:22 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r257DIJ944695714 for ; Tue, 5 Mar 2013 18:13:19 +1100 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r257DL74010964 for ; Tue, 5 Mar 2013 18:13:21 +1100 Message-ID: <51359AB4.4030501@linux.vnet.ibm.com> Date: Tue, 05 Mar 2013 15:11:48 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1361875228-15769-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1361875228-15769-10-git-send-email-xiawenc@linux.vnet.ibm.com> <874ngxhhfv.fsf@blackfin.pond.sub.org> <20130227162229.GJ2514@dhcp-200-207.str.redhat.com> <513009B9.4090406@linux.vnet.ibm.com> <20130304130222.GB18476@stefanha-thinkpad.redhat.com> In-Reply-To: <20130304130222.GB18476@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V7 09/14] block: move bdrv_snapshot_find() to block.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , aliguori@us.ibm.com, Markus Armbruster , qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com 于 2013-3-4 21:02, Stefan Hajnoczi 写道: > On Fri, Mar 01, 2013 at 09:51:53AM +0800, Wenchao Xia wrote: > 于 2013-2-28 0:22, Kevin Wolf 写道: >>> Am 27.02.2013 um 17:04 hat Markus Armbruster geschrieben: >>>> Wenchao Xia writes: >>>> >>>>> Signed-off-by: Wenchao Xia >>>>> Reviewed-by: Eric Blake >>>>> --- >>>>> block.c | 24 ++++++++++++++++++++++++ >>>>> include/block/block.h | 2 ++ >>>>> savevm.c | 22 ---------------------- >>>>> 3 files changed, 26 insertions(+), 22 deletions(-) >>>> >>>> Perhaps savevm.c isn't the best home for snapshot stuff, but I don't >>>> like it in block.c any better. block.c is already unwieldy, and I'd >>>> like us to try limiting it to core block stuff. >>>> >>>> Kevin, Stefan, any ideas? >>> >>> Take some more snapshot related functions from block.c and move them to >>> block/snapshot.c? >>> >>> Kevin >>> >> Hi, Stefan >> Do you also agree about adding new file block/snapshot.c? > > Yes, I agree. > > Stefan > great. Also there are some other functions such as image info collecting, do you think new file block/misc.c is suitable to store those functions there? -- Best Regards Wenchao Xia