From: Paolo Bonzini <pbonzini@redhat.com>
To: liu ping fan <qemulist@gmail.com>
Cc: mdroth <mdroth@linux.vnet.ibm.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] net: introduce lock to protect NetClientState's send_queue
Date: Tue, 05 Mar 2013 09:23:00 +0100 [thread overview]
Message-ID: <5135AB64.4080301@redhat.com> (raw)
In-Reply-To: <CAJnKYQn-Hkp1CAdRBqDtBDp_BNCwuC-yKx1QUU1YNojjfvtFoQ@mail.gmail.com>
Il 05/03/2013 03:45, liu ping fan ha scritto:
> > In fact, it's a bit strange to use nc->something_lock to lock something
> > in nc->peer. Please add the lock to NetQueue and include/net/queue.h.
>
> The lock also servers as exclusion between NetClientState's sender and
> remover. So if we apply lock on NetQueue, it can not achieve the
> goal.
Ok, but please document it.
Paolo
next prev parent reply other threads:[~2013-03-05 8:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-03 13:21 [Qemu-devel] [PATCH 0/3] *** make netlayer re-entrant *** Liu Ping Fan
2013-03-03 13:21 ` [Qemu-devel] [PATCH 1/3] net: spread hub on AioContexts Liu Ping Fan
2013-03-04 14:35 ` Stefan Hajnoczi
2013-03-05 2:45 ` liu ping fan
2013-03-03 13:21 ` [Qemu-devel] [PATCH 2/3] net: introduce lock to protect NetClientState's send_queue Liu Ping Fan
2013-03-04 14:49 ` Stefan Hajnoczi
2013-03-04 15:04 ` Paolo Bonzini
2013-03-05 2:45 ` liu ping fan
2013-03-05 8:23 ` Paolo Bonzini [this message]
2013-03-05 2:45 ` liu ping fan
2013-03-05 3:04 ` liu ping fan
2013-03-05 10:39 ` Stefan Hajnoczi
2013-03-03 13:21 ` [Qemu-devel] [PATCH 3/3] net: make netclient re-entrant with refcnt Liu Ping Fan
2013-03-04 15:19 ` Stefan Hajnoczi
2013-03-05 2:48 ` liu ping fan
2013-03-05 21:30 ` [Qemu-devel] [PATCH 0/3] *** make netlayer re-entrant *** mdroth
2013-03-07 2:06 ` liu ping fan
2013-03-07 9:31 ` Stefan Hajnoczi
2013-03-07 9:33 ` Stefan Hajnoczi
2013-03-11 15:18 ` Paolo Bonzini
2013-03-12 8:41 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5135AB64.4080301@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).