From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCpVr-00011k-49 for qemu-devel@nongnu.org; Tue, 05 Mar 2013 05:54:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCpVp-0000TX-B4 for qemu-devel@nongnu.org; Tue, 05 Mar 2013 05:54:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCpVp-0000TG-1j for qemu-devel@nongnu.org; Tue, 05 Mar 2013 05:54:25 -0500 Message-ID: <5135CE74.7020703@redhat.com> Date: Tue, 05 Mar 2013 11:52:36 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1361875228-15769-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1361875228-15769-10-git-send-email-xiawenc@linux.vnet.ibm.com> <874ngxhhfv.fsf@blackfin.pond.sub.org> <20130227162229.GJ2514@dhcp-200-207.str.redhat.com> <513009B9.4090406@linux.vnet.ibm.com> <20130304130222.GB18476@stefanha-thinkpad.redhat.com> <51359AB4.4030501@linux.vnet.ibm.com> <20130305092105.GB1938@stefanha-thinkpad.redhat.com> <20130305100838.GB3450@dhcp-200-207.str.redhat.com> In-Reply-To: <20130305100838.GB3450@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V7 09/14] block: move bdrv_snapshot_find() to block.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, Stefan Hajnoczi , Markus Armbruster , lcapitulino@redhat.com, Wenchao Xia Il 05/03/2013 11:08, Kevin Wolf ha scritto: >> > >> > As discussed on IRC, it's fine by me. If a better way to organize these >> > functions becomes clear in the future they can be moved. > As also discussed on IRC, I'm not excited by having a block/misc.c. We > already have something for "everything block related that doesn't fit > elsewhere" and it's block.c. I couldn't tell if a function belong into > block.c or block/misc.c. > > I suggested having a file that concentrates all function related to > QAPI, the monitor and JSON (including the qemu-img JSON output) and call > it something like block/qapi.c (I'm open for better suggestions). This > would at least make it clear if a function should be in there or not. I agree with Kevin. Paolo