From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: rusty@rustcorp.com.au,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] QEMU -netdev vhost=on + -device virtio-net-pci bug
Date: Wed, 06 Mar 2013 00:21:47 +1100 [thread overview]
Message-ID: <5135F16B.2010403@ozlabs.ru> (raw)
In-Reply-To: <20130305125614.GA2256@redhat.com>
On 05/03/13 23:56, Michael S. Tsirkin wrote:
>> The patch f56a12475ff1b8aa61210d08522c3c8aaf0e2648 "vhost: backend
>> masking support" breaks virtio-net + vhost=on on PPC64 platform.
>>
>> The problem command line is:
>> 1) -netdev tap,id=tapnet,ifname=tap0,script=qemu-ifup.sh,vhost=on \
>> -device virtio-net-pci,netdev=tapnet,addr=0.0 \
>
> I think the issue is irqfd in not supported on kvm ppc.
How can I make sure this is the case? Some work has been done there
recently but midnight is quite late to figure this out :)
> Could you please check this:
>
> + /* If guest supports masking, set up irqfd now.
> + * Otherwise, delay until unmasked in the frontend.
> + */
> + if (proxy->vdev->guest_notifier_mask) {
> + ret = kvm_virtio_pci_irqfd_use(proxy, queue_no, vector);
> + if (ret < 0) {
> + kvm_virtio_pci_vq_vector_release(proxy, vector);
> + goto undo;
> + }
> + }
>
>
> Could you please add a printf before "undo" and check whether the
> error path above is triggered?
Checked, it is not triggered.
--
Alexey
next prev parent reply other threads:[~2013-03-05 13:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 6:55 [Qemu-devel] QEMU -netdev vhost=on + -device virtio-net-pci bug Alexey Kardashevskiy
2013-03-05 12:56 ` Michael S. Tsirkin
2013-03-05 13:21 ` Alexey Kardashevskiy [this message]
2013-03-05 14:23 ` Michael S. Tsirkin
2013-03-05 22:57 ` Alexey Kardashevskiy
2013-03-06 10:31 ` Michael S. Tsirkin
2013-03-08 4:48 ` Alexey Kardashevskiy
2013-03-10 9:24 ` Michael S. Tsirkin
2013-03-10 11:25 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5135F16B.2010403@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).