From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37536)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1UCrnX-0006C0-Dl
	for qemu-devel@nongnu.org; Tue, 05 Mar 2013 08:20:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1UCrnV-0004f7-BE
	for qemu-devel@nongnu.org; Tue, 05 Mar 2013 08:20:51 -0500
Received: from mail-ia0-x234.google.com ([2607:f8b0:4001:c02::234]:40952)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1UCrnU-0004ey-Io
	for qemu-devel@nongnu.org; Tue, 05 Mar 2013 08:20:49 -0500
Received: by mail-ia0-f180.google.com with SMTP id f27so5931115iae.39
	for <qemu-devel@nongnu.org>; Tue, 05 Mar 2013 05:20:48 -0800 (PST)
Message-ID: <5135F16B.2010403@ozlabs.ru>
Date: Wed, 06 Mar 2013 00:21:47 +1100
From: Alexey Kardashevskiy <aik@ozlabs.ru>
MIME-Version: 1.0
References: <513596D7.3060307@ozlabs.ru> <20130305125614.GA2256@redhat.com>
In-Reply-To: <20130305125614.GA2256@redhat.com>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] QEMU -netdev vhost=on + -device virtio-net-pci bug
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: rusty@rustcorp.com.au, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, David Gibson <david@gibson.dropbear.id.au>

On 05/03/13 23:56, Michael S. Tsirkin wrote:
>> The patch f56a12475ff1b8aa61210d08522c3c8aaf0e2648 "vhost: backend
>> masking support" breaks virtio-net + vhost=on on PPC64 platform.
>>
>> The problem command line is:
>> 1) -netdev tap,id=tapnet,ifname=tap0,script=qemu-ifup.sh,vhost=on \
>> -device virtio-net-pci,netdev=tapnet,addr=0.0 \
>
> I think the issue is irqfd in not supported on kvm ppc.

How can I make sure this is the case? Some work has been done there
recently but midnight is quite late to figure this out :)


> Could you please check this:
>
> +        /* If guest supports masking, set up irqfd now.
> +         * Otherwise, delay until unmasked in the frontend.
> +         */
> +        if (proxy->vdev->guest_notifier_mask) {
> +            ret = kvm_virtio_pci_irqfd_use(proxy, queue_no, vector);
> +            if (ret < 0) {
> +                kvm_virtio_pci_vq_vector_release(proxy, vector);
> +                goto undo;
> +            }
> +        }
>
>
> Could you please add a printf before "undo" and check whether the
> error path above is triggered?


Checked, it is not triggered.


-- 
Alexey