From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39912)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1UCuOp-0008QD-C0
	for qemu-devel@nongnu.org; Tue, 05 Mar 2013 11:07:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1UCuOn-0004Np-Sb
	for qemu-devel@nongnu.org; Tue, 05 Mar 2013 11:07:31 -0500
Received: from goliath.siemens.de ([192.35.17.28]:30607)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1UCuOn-0004NO-HV
	for qemu-devel@nongnu.org; Tue, 05 Mar 2013 11:07:29 -0500
Message-ID: <5136183C.5080705@siemens.com>
Date: Tue, 05 Mar 2013 17:07:24 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1362499399-19475-1-git-send-email-chouteau@adacore.com>
	<1362499399-19475-2-git-send-email-chouteau@adacore.com>
In-Reply-To: <1362499399-19475-2-git-send-email-chouteau@adacore.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] Revert "gdbstub: Do not kill target in
 system emulation mode"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 2013-03-05 17:03, Fabien Chouteau wrote:
> This reverts commit 00e94dbc7fd0110b0555d59592b004333adfb4b8.

Should also tell us why (by pointing to the other commit e.g.).

Will give this a try ASAP!

Thanks,
Jan

> 
> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
> ---
>  gdbstub.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/gdbstub.c b/gdbstub.c
> index c0686a9..22078df 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -2181,11 +2181,9 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)
>              goto unknown_command;
>          }
>      case 'k':
> -#ifdef CONFIG_USER_ONLY
>          /* Kill the target */
>          fprintf(stderr, "\nQEMU: Terminated via GDBstub\n");
>          exit(0);
> -#endif
>      case 'D':
>          /* Detach packet */
>          gdb_breakpoint_remove_all();
> 

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux