From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCuSw-0005hw-T7 for qemu-devel@nongnu.org; Tue, 05 Mar 2013 11:11:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCuSr-0006LQ-8K for qemu-devel@nongnu.org; Tue, 05 Mar 2013 11:11:46 -0500 Received: from cantor2.suse.de ([195.135.220.15]:48700 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCuSr-00066c-3K for qemu-devel@nongnu.org; Tue, 05 Mar 2013 11:11:41 -0500 Message-ID: <51361913.2010007@suse.de> Date: Tue, 05 Mar 2013 17:10:59 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1362495898-15352-1-git-send-email-pbonzini@redhat.com> <1362495898-15352-2-git-send-email-pbonzini@redhat.com> <87zjyhsvpv.fsf@codemonkey.ws> In-Reply-To: <87zjyhsvpv.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/3] cpu: make CPU_INTERRUPT_RESET available on all targets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori , Paolo Bonzini Cc: dwmw2@infradead.org, lersek@redhat.com, qemu-devel@nongnu.org Am 05.03.2013 16:38, schrieb Anthony Liguori: > Paolo Bonzini writes: >=20 >> On the x86, some devices need access to the CPU reset pin (INIT#). >> Provide a generic service to do this, using one of the internal >> cpu_interrupt targets. Generalize the PPC-specific code for >> CPU_INTERRUPT_RESET to other targets, and provide a function that >> will raise the interrupt on all CPUs. >> >> Since PPC does not support migration, I picked the value that is >> used on x86, CPU_INTERRUPT_TGT_INT_1. No other arch used to use >> CPU_INTERRUPT_TGT_INT_1. >> >> Signed-off-by: Paolo Bonzini >=20 > This is a very nice approach. >=20 > It would still be nice to remove the explicit reset registrations for > the various cpus and instead just call cpu_soft_reset(). >=20 > I'm not sure "soft" is the best word. This is just a normal CPU reset > but I won't bikeshed over that. >=20 > Reviewed-by: Anthony Liguori I would like to take this through qom-cpu please since I already changed cpu_interrupt() to CPUState with my last patch series, for which the prereqs got an Rb now. cpu_soft_reset() still needs to live outside qom/cpu.c due to the CPU iteration, so this would be purely mechanical. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg