From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41743)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UCvtc-0005Hx-8h
	for qemu-devel@nongnu.org; Tue, 05 Mar 2013 12:43:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UCvtb-0004QE-3m
	for qemu-devel@nongnu.org; Tue, 05 Mar 2013 12:43:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33760)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UCvta-0004Q7-RS
	for qemu-devel@nongnu.org; Tue, 05 Mar 2013 12:43:23 -0500
Message-ID: <51362EA0.5020400@redhat.com>
Date: Tue, 05 Mar 2013 18:42:56 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1362499403-16514-1-git-send-email-pbonzini@redhat.com>
	<1362502791.32301.13.camel@i7.infradead.org>
	<513626F5.6030106@redhat.com> <20130305172636.14123.qmail@stuge.se>
In-Reply-To: <20130305172636.14123.qmail@stuge.se>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Stuge <peter@stuge.se>
Cc: lersek@redhat.com, aliguori@us.ibm.com, Kevin O'Connor <kevin@koconnor.net>, David Woodhouse <dwmw2@infradead.org>, qemu-devel@nongnu.org

Il 05/03/2013 18:26, Peter Stuge ha scritto:
>>> > > That is: perhaps it's a *SeaBIOS* bug that suspend/resume doesn't
>>> > > work if the PAM configuration is reset?
>> > 
>> > Yeah, it sounded a bit weird when I wrote that commit message. 
>> > This could be the case.  How does it work on Coreboot?
> Yes all hardware except RAM in self-refresh and registers explicitly
> hooked to battery sleep power rail has reset state on resume from S3.
> Those registers seem to grow over time, the i440 probably doesn't
> have very many. The memory controller configuration would be stored
> there.

Ok, so it's not correct either with this patch or without. :)

But without this patch it is more correct; things such as USB queue
heads must be reset, or you'll corrupt random memory when the VM is
restarted.

Paolo