From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCxcG-0005N7-K3 for qemu-devel@nongnu.org; Tue, 05 Mar 2013 14:33:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCxcD-0007UW-IF for qemu-devel@nongnu.org; Tue, 05 Mar 2013 14:33:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCxcD-0007UO-B3 for qemu-devel@nongnu.org; Tue, 05 Mar 2013 14:33:33 -0500 Message-ID: <51364905.2010308@redhat.com> Date: Tue, 05 Mar 2013 20:35:33 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1362510056-3316-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1362510056-3316-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/3] Implement x86 soft reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, dwmw2@infradead.org, qemu-devel@nongnu.org, afaerber@suse.de On 03/05/13 20:00, Paolo Bonzini wrote: > This series makes various devices (port 92h, pckbd and the > PIIX4/ICH9 southbridges) implement x86 soft reset correctly. > > v1->v2: rebased onto Andreas's branch, fixed target-ppc/cpu.h, > renamed function > > Paolo Bonzini (3): > cpu: make CPU_INTERRUPT_RESET available on all targets > pc: port 92 reset requires a low->high transition > hw: correctly implement soft reset > > cpu-exec.c | 24 ++++++++++++++---------- > cpus.c | 9 +++++++++ > hw/lpc_ich9.c | 7 ++++++- > hw/pc.c | 6 ++++-- > hw/pckbd.c | 5 +++-- > hw/piix_pci.c | 8 ++++++-- > include/exec/cpu-all.h | 8 +++++--- > include/sysemu/cpus.h | 1 + > target-i386/cpu.h | 7 ++++--- > target-ppc/cpu.h | 3 --- > 10 files changed, 52 insertions(+), 26 deletions(-) > You haven't addressed the difference on soft reset between ich9_rst_cnt_write() and rcr_write() that I pointed out in v1 3/3, but I can live with that. Series Reviewed-by: Laszlo Ersek