From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDEig-0005Ak-Fh for qemu-devel@nongnu.org; Wed, 06 Mar 2013 08:49:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDEib-0007nm-HS for qemu-devel@nongnu.org; Wed, 06 Mar 2013 08:49:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDEib-0007ng-83 for qemu-devel@nongnu.org; Wed, 06 Mar 2013 08:49:17 -0500 Message-ID: <51374958.7030907@redhat.com> Date: Wed, 06 Mar 2013 06:49:12 -0700 From: Eric Blake MIME-Version: 1.0 References: <1362435597-20018-1-git-send-email-lersek@redhat.com> <1362435597-20018-2-git-send-email-lersek@redhat.com> <51365EC2.8050903@redhat.com> <51367A50.6040405@redhat.com> In-Reply-To: <51367A50.6040405@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2BQFVIGJRFMADMPNNDEFX" Subject: Re: [Qemu-devel] [PATCH 1/3] qga: introduce guest-get-vcpus / guest-set-vcpus with stubs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Drew Jones , qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, pbonzini@redhat.com, lcapitulino@redhat.com, Karen Noel This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2BQFVIGJRFMADMPNNDEFX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/05/2013 04:05 PM, Laszlo Ersek wrote: >>> +# If part or whole of the requested operation can't be carried out, = the guest >>> +# VCPU state will be unspecified. >> >> Completely unspecified? >=20 > Yes. "Unspecified" means "valid" (ie. at least one VCPU will be online,= > the guest won't be "dead"), but no further info will be returned at onc= e. Hmm, just thinking aloud here (not saying we need to swap interfaces, unless you like this alternative): What if we have guest-set-vcpus return a non-negative integer on success; namely, the number of consecutive array actions that were completed, and guarantee successful exit on first failure if any prior element was acted on? Passing an empty array, or failing on the first array element, would give an error; otherwise, the error is lost if a user batches commands, but they would know how much of the batch failed, and can retry the command with the failing entry first to see what the failure was (assuming the failure is reproducible). Basically, this would make guest-set-vcpus do partial write detection somewhat like write= (). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2BQFVIGJRFMADMPNNDEFX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRN0lYAAoJEKeha0olJ0Nq2dUH+wYy07PpvFzHOpeTh4bm7Gqt xwQvuwNo++DXP/tvhNWkUKQUyIfzh4KZct+K9h6FEBSjPJbbWGRIhNek5nJIlu04 GbLLTP6rZ3yGeJ0nRKTPLn6J3UIAu2+N0f5AoYSwCHXLP53pqRldQ6LY//MzhpTm /WsJwpci3S7lIU9Ogck7is9p1+8e4lilQapx55pumCl4F5u/G0IFV8E3qRGK4G3Z SUyUSK7Av0A2t5Y1H9jJGMtgRcMjiFi/xaQ2fdxMf5Fazkd829mSwS7c+V5Cd2v/ 5olJexP8IZHgGJvtIB2w6ojNzAz1uqsAUzzj+fmbsGxV5QwfE6SfYBEvrmSDWZk= =6rDi -----END PGP SIGNATURE----- ------enig2BQFVIGJRFMADMPNNDEFX--