From: Paolo Bonzini <pbonzini@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-sockets: Fix assertion failure
Date: Wed, 06 Mar 2013 16:04:36 +0100 [thread overview]
Message-ID: <51375B04.9020402@redhat.com> (raw)
In-Reply-To: <513756D5.1020506@redhat.com>
Il 06/03/2013 15:46, Laszlo Ersek ha scritto:
>> > We could assert(!error_is_set(errp)) if we wanted. As soon as you've got
>> > an Error, you must return instead of calling more functions with the
>> > same error pointer.
> I think Luiz would suggest (*) to receive any error into a
> NULL-initialized local_err pointer; do the logic above on local_err, and
> just before returning, error_propagate() it to errp.
>
> (*) I hope you can see what I did there: if you disagree, you get to
> take that to Luiz, even though he didn't say anything. I'm getting
> better at working this list! :)
I agree with Laszlo.
Paolo
next prev parent reply other threads:[~2013-03-06 15:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 10:48 [Qemu-devel] [PATCH] qemu-sockets: Fix assertion failure Kevin Wolf
2013-03-06 11:04 ` Paolo Bonzini
2013-03-06 11:11 ` Kevin Wolf
2013-03-06 14:46 ` Laszlo Ersek
2013-03-06 15:04 ` Paolo Bonzini [this message]
2013-03-06 15:19 ` Kevin Wolf
2013-03-06 15:38 ` Laszlo Ersek
2013-03-06 15:47 ` Kevin Wolf
2013-03-06 16:04 ` Laszlo Ersek
2013-03-06 15:59 ` Markus Armbruster
2013-03-06 16:43 ` Paolo Bonzini
2013-03-14 14:57 ` [Qemu-devel] [RFC PATCH] qemu-socket: Use local error variable Kevin Wolf
2013-03-14 15:52 ` Laszlo Ersek
2013-03-15 8:37 ` Kevin Wolf
2013-03-15 16:55 ` Laszlo Ersek
2013-03-15 17:55 ` Kevin Wolf
2013-03-15 18:39 ` Laszlo Ersek
2013-03-19 20:34 ` [Qemu-devel] [PATCH] qemu-sockets: Fix assertion failure Luiz Capitulino
2013-03-20 8:39 ` Kevin Wolf
2013-03-20 12:57 ` Luiz Capitulino
2013-03-20 13:37 ` Kevin Wolf
2013-03-20 13:52 ` Luiz Capitulino
2013-03-06 15:05 ` Markus Armbruster
2013-03-06 15:05 ` [Qemu-devel] Error ** parameter conventions (was: [PATCH] qemu-sockets: Fix assertion failure) Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51375B04.9020402@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).