From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59771) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDFtc-0005lq-JA for qemu-devel@nongnu.org; Wed, 06 Mar 2013 10:04:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDFtY-0008W2-0N for qemu-devel@nongnu.org; Wed, 06 Mar 2013 10:04:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:62550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDFtX-0008Vs-QC for qemu-devel@nongnu.org; Wed, 06 Mar 2013 10:04:39 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r26F4dhe031231 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 6 Mar 2013 10:04:39 -0500 Message-ID: <51375B04.9020402@redhat.com> Date: Wed, 06 Mar 2013 16:04:36 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1362566886-14073-1-git-send-email-kwolf@redhat.com> <513722BD.6010503@redhat.com> <20130306111126.GA2285@dhcp-200-207.str.redhat.com> <513756D5.1020506@redhat.com> In-Reply-To: <513756D5.1020506@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qemu-sockets: Fix assertion failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Kevin Wolf , qemu-devel@nongnu.org, Luiz Capitulino Il 06/03/2013 15:46, Laszlo Ersek ha scritto: >> > We could assert(!error_is_set(errp)) if we wanted. As soon as you've got >> > an Error, you must return instead of calling more functions with the >> > same error pointer. > I think Luiz would suggest (*) to receive any error into a > NULL-initialized local_err pointer; do the logic above on local_err, and > just before returning, error_propagate() it to errp. > > (*) I hope you can see what I did there: if you disagree, you get to > take that to Luiz, even though he didn't say anything. I'm getting > better at working this list! :) I agree with Laszlo. Paolo