qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Anthony Liguori" <aliguori@us.ibm.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@gmail.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Luiz Capitulino" <lcapitulino@redhat.com>,
	"libvir-list@redhat.com" <libvir-list@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	laine@redhat.com, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event
Date: Wed, 06 Mar 2013 08:41:02 -0700	[thread overview]
Message-ID: <5137638E.5000207@redhat.com> (raw)
In-Reply-To: <51375842.1090700@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]

[adding libvirt]

On 03/06/2013 07:52 AM, Paolo Bonzini wrote:
> Il 06/03/2013 15:44, Eric Blake ha scritto:
>> Question - if libvirt misses the event (for example, if libvirtd
>> requests a remove, but then gets restarted, and the event arrives before
>> libvirtd is back up), is there a way to poll whether the the removal has
>> completed?  The event is great to minimize polling overhead in the
>> common case, but we generally provide this sort of information via a
>> pollable interface at the same time.
> 
> Yes, you can use qom-list on /machine/peripheral.

Which means libvirt should be patched to use qom-list right now, even
before this event makes it in, in order to avoid its current bug of
reusing a device id before the deletion has completed.  Adding the event
is still useful, as polling is never nice; and we already know how to
make libvirt do conditional code based on whether query-events shows
that the event has been added to minimize polling where possible.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]

  reply	other threads:[~2013-03-06 15:41 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-06 13:00 [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event Michael S. Tsirkin
2013-03-06 13:57 ` Andreas Färber
2013-03-06 14:13   ` Michael S. Tsirkin
2013-03-07  9:55     ` Markus Armbruster
2013-03-07 10:07       ` Michael S. Tsirkin
2013-03-07 13:11         ` Andreas Färber
2013-03-07 14:14           ` Markus Armbruster
2013-03-07 16:35             ` Michael S. Tsirkin
2013-03-07 17:23               ` Markus Armbruster
2013-03-07 18:12                 ` Michael S. Tsirkin
2013-03-07 19:00                   ` Andreas Färber
2013-03-07 19:15                     ` Michael S. Tsirkin
2013-03-08  7:09                       ` Osier Yang
2013-03-08  8:50                         ` Markus Armbruster
2013-03-08  9:25                           ` Jiri Denemark
2013-03-08 10:37                             ` Osier Yang
2013-03-08 10:56                           ` Osier Yang
2013-03-08 11:58                             ` Markus Armbruster
2013-03-07 20:18                   ` Markus Armbruster
2013-03-07 20:29                     ` Michael S. Tsirkin
2013-03-06 14:44 ` Eric Blake
2013-03-06 14:50   ` Michael S. Tsirkin
2013-03-06 14:52   ` Paolo Bonzini
2013-03-06 15:41     ` Eric Blake [this message]
2013-03-07  9:38       ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5137638E.5000207@redhat.com \
    --to=eblake@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=laine@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).