From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49058)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UDGnM-0003Pl-US
	for qemu-devel@nongnu.org; Wed, 06 Mar 2013 11:02:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UDGnJ-0004St-MR
	for qemu-devel@nongnu.org; Wed, 06 Mar 2013 11:02:20 -0500
Received: from mx1.redhat.com ([209.132.183.28]:34164)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UDGnJ-0004Sk-En
	for qemu-devel@nongnu.org; Wed, 06 Mar 2013 11:02:17 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r26G2GEK008032
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 6 Mar 2013 11:02:16 -0500
Message-ID: <51376905.4060607@redhat.com>
Date: Wed, 06 Mar 2013 17:04:21 +0100
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1362566886-14073-1-git-send-email-kwolf@redhat.com>
	<513722BD.6010503@redhat.com>
	<20130306111126.GA2285@dhcp-200-207.str.redhat.com>
	<513756D5.1020506@redhat.com> <51375B04.9020402@redhat.com>
	<20130306151905.GB2285@dhcp-200-207.str.redhat.com>
	<513762EF.3030809@redhat.com>
	<20130306154731.GE2285@dhcp-200-207.str.redhat.com>
In-Reply-To: <20130306154731.GE2285@dhcp-200-207.str.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qemu-sockets: Fix assertion failure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On 03/06/13 16:47, Kevin Wolf wrote:
> Am 06.03.2013 um 16:38 hat Laszlo Ersek geschrieben:

>> Of course one wonders why a caller would pass in a preexistent Error.
> 
> Thanks, Laszlo, now I think I understand what Paolo and you were
> suggesting.
> 
> However, I'd call any such caller buggy and don't feel like adding code
> so that it doesn't break. This is what I meant when I said you should
> return when you get an error, and not call other functions with the
> already used error pointer.

I don't disagree. I'm certainly not blocking your patch! :)

Laszlo