From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDJAM-0001B6-PB for qemu-devel@nongnu.org; Wed, 06 Mar 2013 13:34:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDJAH-0003mc-Fo for qemu-devel@nongnu.org; Wed, 06 Mar 2013 13:34:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDJAH-0003mI-8o for qemu-devel@nongnu.org; Wed, 06 Mar 2013 13:34:09 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r26IY8AB003871 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 6 Mar 2013 13:34:08 -0500 Message-ID: <51378C1E.6060904@redhat.com> Date: Wed, 06 Mar 2013 11:34:06 -0700 From: Eric Blake MIME-Version: 1.0 References: <1362594402-6917-1-git-send-email-quintela@redhat.com> In-Reply-To: <1362594402-6917-1-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2NFJRCHOSKEKWCMEMWODG" Subject: Re: [Qemu-devel] [PATCH v2] migration: Improve QMP documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2NFJRCHOSKEKWCMEMWODG Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/06/2013 11:26 AM, Juan Quintela wrote: > v2: > Add Markus sugestions: If you keep this in the commit message, then s/sugestions/suggestions/ >=20 > Signed-off-by: Juan Quintela > --- But it's better to stick patch changelog (your v2 comment) here, after the ---, since it is nice for reviewers but useless information in the git logs. > + - "duplicate": number of pages filled entirely with the same > + byte (json-int) > + These are sent over the wire much more efficiently. TAB damage. Contents look fine, so once the commit message and whitespace is fixed, feel free to add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2NFJRCHOSKEKWCMEMWODG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRN4weAAoJEKeha0olJ0NqxakH/2+9sjcgLFRrlAeU4x4uN6An SAl1B3VjYgfgUQv4LAWTR6yCcvfVyFvNoVn2mdHLmn42kvGEgQXdSoSraCRH2JZN hh2HQvFEwy5JK1N3uZmtU5suTGiJJTnX4mXjuIr4AnYVx/t0qdhR1zIzRLS6/2q1 +GxbRz/Xb3T7JoUEdVjfEe3dq90d8QWSkCv9j3MpZ9R1U7iCuSH+16B/a83DbGSu d6gZ3zLH3yDK56h/ojfGSSii27ZtJ5TQmFnQz99WJqtj5trEZLvoc9jH+J2M3Qdw ZgPyODoaGwUw1y0agyjtQ7Oj6NsQrB4OkF0wAV1BV3vNYr169WLaAT+/N+xLyRM= =M5gs -----END PGP SIGNATURE----- ------enig2NFJRCHOSKEKWCMEMWODG--