From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDNZf-0003kD-2O for qemu-devel@nongnu.org; Wed, 06 Mar 2013 18:16:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDNZd-0003Li-NW for qemu-devel@nongnu.org; Wed, 06 Mar 2013 18:16:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35256) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDNZd-0003Lc-EP for qemu-devel@nongnu.org; Wed, 06 Mar 2013 18:16:37 -0500 Message-ID: <5137CE15.1080206@redhat.com> Date: Wed, 06 Mar 2013 16:15:33 -0700 From: Eric Blake MIME-Version: 1.0 References: <1362607171-24668-1-git-send-email-lersek@redhat.com> <1362607171-24668-3-git-send-email-lersek@redhat.com> In-Reply-To: <1362607171-24668-3-git-send-email-lersek@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2DAVSPKJQGSQXRTHSRWFX" Subject: Re: [Qemu-devel] [PATCH v2 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2DAVSPKJQGSQXRTHSRWFX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/06/2013 02:59 PM, Laszlo Ersek wrote: > Signed-off-by: Laszlo Ersek > --- > qga/commands-posix.c | 146 ++++++++++++++++++++++++++++++++++++++++++= +++++-- > 1 files changed, 140 insertions(+), 6 deletions(-) >=20 > @@ -1027,6 +1031,136 @@ error: > return NULL; > } > =20 > +#define SYSCONF_EXACT(name, err) sysconf_exact((name), #name, (err)) Technically, the inner () are redundant (in a parameter list, there is no syntax that can be rendered differently if you called sysconf_exact(name, #name, err)); but I don't mind keeping them for style purposes (the rule of thumb of parenthesizing macro parameters for safety is a bit easier to remember if you always do it, even when it is redundant). > + vcpu->has_can_offline =3D true; /* lolspeak ftw */ Indeed :) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2DAVSPKJQGSQXRTHSRWFX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRN84WAAoJEKeha0olJ0NqVacH/1YVjLnI9AvI0JGIKh/pMoPm vvk88BKxpt/XS8I8WvQ1ilGvgvNhz2zAlcYdD5bBgBKo0MpfvDpGdre1yDJiuZlU jbNosCGKzo7Zxl+Sl48hAKU8/3AvXmn+b6x9Ydg0EaTgjE96UoVJOsB0APHYS6n/ mojgwdjC9O46mVetesbh6I+s8hoG0dv39HyRET2HUzj5qVs9yI5EyfJbYh6TTF37 pIoGN+OulT2hD5CB3jOAfu4Mh1et4+ZOQ7560QOZC7LCATzLHM6AZd2dgLc2Q12P 7msnR2DrfrIr7/3bV50nVmtCHtrwyekB3+K4L37PRRzlIZn+xAnwSxX7nPmqFks= =JZeX -----END PGP SIGNATURE----- ------enig2DAVSPKJQGSQXRTHSRWFX--