From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDcUj-0006Ui-Fb for qemu-devel@nongnu.org; Thu, 07 Mar 2013 10:12:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDcUh-00029q-Q6 for qemu-devel@nongnu.org; Thu, 07 Mar 2013 10:12:33 -0500 Received: from e7.ny.us.ibm.com ([32.97.182.137]:36799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDcUh-00028i-N7 for qemu-devel@nongnu.org; Thu, 07 Mar 2013 10:12:31 -0500 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 Mar 2013 10:12:28 -0500 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id CB3526E8061 for ; Thu, 7 Mar 2013 10:12:24 -0500 (EST) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r27FCQvm25297032 for ; Thu, 7 Mar 2013 10:12:26 -0500 Received: from d01av05.pok.ibm.com (loopback [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r27FBJHq026672 for ; Thu, 7 Mar 2013 10:11:19 -0500 Message-ID: <5138AE17.4040607@linux.vnet.ibm.com> Date: Thu, 07 Mar 2013 10:11:19 -0500 From: Corey Bryant MIME-Version: 1.0 References: <1362207528-27804-1-git-send-email-cardoe@cardoe.com> <1362637930-8499-1-git-send-email-cardoe@cardoe.com> In-Reply-To: <1362637930-8499-1-git-send-email-cardoe@cardoe.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv3 0/2] bridge helper: includedir conf arg List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Doug Goldstein Cc: qemu-devel@nongnu.org On 03/07/2013 01:32 AM, Doug Goldstein wrote: > The goal is to support an 'includedir' to include all files within a > directory specified in the bridge.conf file. The rationale is to allow > libvirt to be able to configure interfaces to for use by unprivileged > users by just simply generating a new configuration file to the directory. > > Change from v2: > - Integrated review changes from Corey Bryant > - Integrated review changes from Stefan Hajnoczi > > Change from v1: > - Reversed patch order to make the series clearer > - Integrated review changes from Corey Bryant > - Integrated review changes from Stefan Hajnoczi > > Doug Goldstein (2): > bridge helper: unified error cleanup for parse_acl_file > bridge helper: support conf dirs > > qemu-bridge-helper.c | 83 ++++++++++++++++++++++++++++++++++++++++++++-------- > 1 file changed, 71 insertions(+), 12 deletions(-) > Reviewed-by: Corey Bryant -- Regards, Corey Bryant