From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52817)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UDdNh-0007Vn-HH
	for qemu-devel@nongnu.org; Thu, 07 Mar 2013 11:09:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UDdNc-0005lG-Pr
	for qemu-devel@nongnu.org; Thu, 07 Mar 2013 11:09:21 -0500
Received: from mail-qe0-f44.google.com ([209.85.128.44]:52736)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UDdNc-0005lC-Lr
	for qemu-devel@nongnu.org; Thu, 07 Mar 2013 11:09:16 -0500
Received: by mail-qe0-f44.google.com with SMTP id x7so375706qeu.3
	for <qemu-devel@nongnu.org>; Thu, 07 Mar 2013 08:09:16 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5138BBA7.5030903@redhat.com>
Date: Thu, 07 Mar 2013 17:09:11 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1362580930.git.jcody@redhat.com>
	<a56a55df5012c863f79cdb45ce2ba5a886ac37f4.1362580930.git.jcody@redhat.com>
	<51378200.5010705@dlhnet.de> <513785A0.1010001@redhat.com>
	<20130306181454.GB3743@localhost.localdomain>
	<51378B97.2000709@redhat.com>
	<20130306184800.GB22782@localhost.localdomain>
	<51379304.50307@dlhnet.de> <5137A964.5020803@redhat.com>
	<513855A7.7070205@dlhnet.de>
In-Reply-To: <513855A7.7070205@dlhnet.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/7] block: only force IO completion in
 .bdrv_truncate if we are shrinking
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@dlhnet.de>
Cc: kwolf@redhat.com, sw@weilnetz.de, Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com

Il 07/03/2013 09:53, Peter Lieven ha scritto:
>>
>> Then we can add bdrv_revalidate and, for block_resize, call
>> bdrv_revalidate+bdrv_truncate.  For bs->growable = 0 &&
>> !bs->drv->bdrv_truncate, bdrv_truncate can just check that the actual
>> size is the same or bigger as the one requested, and fail otherwise.
>>
> 
> Regarding brd_drain_all(). Is the fix right to call it only on device
> shrink?

I think the fix is to only call it for the monitor command.  Optionally,
when shrinking, assert that there are no requests in flight.

Paolo

> In this case it has to be added to iscsi_truncate as well.