From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDtX1-0005P2-0u for qemu-devel@nongnu.org; Fri, 08 Mar 2013 04:24:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDtWz-0008Nm-Mu for qemu-devel@nongnu.org; Fri, 08 Mar 2013 04:24:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:65263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDtWz-0008Ne-FT for qemu-devel@nongnu.org; Fri, 08 Mar 2013 04:24:01 -0500 Message-ID: <5139AE29.9020106@redhat.com> Date: Fri, 08 Mar 2013 10:23:53 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <51378200.5010705@dlhnet.de> <513785A0.1010001@redhat.com> <20130306181454.GB3743@localhost.localdomain> <51378B97.2000709@redhat.com> <20130306184800.GB22782@localhost.localdomain> <51379304.50307@dlhnet.de> <5137A964.5020803@redhat.com> <513855A7.7070205@dlhnet.de> <5138BBA7.5030903@redhat.com> <51399911.1060006@dlhnet.de> In-Reply-To: <51399911.1060006@dlhnet.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/7] block: only force IO completion in .bdrv_truncate if we are shrinking List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, sw@weilnetz.de, Jeff Cody , qemu-devel@nongnu.org, stefanha@redhat.com Il 08/03/2013 08:53, Peter Lieven ha scritto: >> >> I think the fix is to only call it for the monitor command. Optionally, >> when shrinking, assert that there are no requests in flight. > > Okay. > > What is the plan? just fix this or fix the whole thing (which seems to > be some > work). > > The suggested patch from Jeff will break iscsi_truncate as bs->growable > is 1 currently. I guess it's up to Kevin and Jeff. Paolo