From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UE3dU-0005Vw-37 for qemu-devel@nongnu.org; Fri, 08 Mar 2013 15:11:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UE3dM-000273-EY for qemu-devel@nongnu.org; Fri, 08 Mar 2013 15:11:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UE3dM-00026q-2Y for qemu-devel@nongnu.org; Fri, 08 Mar 2013 15:11:16 -0500 Message-ID: <513A45DF.1020201@redhat.com> Date: Fri, 08 Mar 2013 13:11:11 -0700 From: Eric Blake MIME-Version: 1.0 References: <1362761807-32475-1-git-send-email-lilei@linux.vnet.ibm.com> <1362761807-32475-3-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1362761807-32475-3-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2BQIHEWHDPPWNJBNHEALF" Subject: Re: [Qemu-devel] [PATCH 2/2] qga: add windows implementation for guest-set-time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2BQIHEWHDPPWNJBNHEALF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/08/2013 09:56 AM, Lei Li wrote: > Signed-off-by: Lei Li > --- > qga/commands-win32.c | 35 +++++++++++++++++++++++++++++++++++ > 1 files changed, 35 insertions(+), 0 deletions(-) >=20 > + > + time =3D time_ns / 100 + W32_FT_OFFSET; > + /* FILETIME values should be less than 0x8000000000000000 > + for function FileTimeToSystemTime. */ > + if (time & 0x8000000000000000) { > + error_setg(errp, "Time %" PRId64 "is too large", time); > + return; > + } That doesn't cover all cases of overflow. Better would be: if (time_ns < 0 || time_ns / 100 > INT64_MAX - W32_FT_OFFSET) { error ... } time =3D time_ns / 100 + W32_FT_OFFSET; --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2BQIHEWHDPPWNJBNHEALF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJROkXgAAoJEKeha0olJ0Nq9N8IAJN6ppMEuI1+tBdDLaDn4+Y7 NBUUyKrcXeWC+ccVfzHzM6HvKmnGApEmN+DXyF4c5HTG2hsKm4IyjGZDgDxxMWwi bnppfdNW74E8Sf31pToS9OQJYNK0Ut2CWm64ODAFNhkvPN1OL+oy4p0lv5uf0ajK wOGctcT9ayIw2y773AnVx3Qd+TGk66TGzt2rIl3WGujtjJkB4tMS55nK63HjG4+4 IwqVP/abue2hOSxz2BB07vcz/1boqgk93eMuFgExmFfkH9UPz7mIXtQU+341vKDj 574Sck70QamKaTFbP/UzcQfcCL9pzIGmNlEKnFMiFByqBN6LhUEPjYOrOBYZqgM= =P8C8 -----END PGP SIGNATURE----- ------enig2BQIHEWHDPPWNJBNHEALF--