From: Eric Blake <eblake@redhat.com>
To: Lei Li <lilei@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time
Date: Fri, 08 Mar 2013 13:12:31 -0700 [thread overview]
Message-ID: <513A462F.3030606@redhat.com> (raw)
In-Reply-To: <1362761807-32475-2-git-send-email-lilei@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 579 bytes --]
On 03/08/2013 09:56 AM, Lei Li wrote:
> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> ---
> qga/commands-win32.c | 32 ++++++++++++++++++++++++++++++++
> 1 files changed, 32 insertions(+), 0 deletions(-)
>
> +
> + time_ns = (int64_t)((time.ns100 - W32_FT_OFFSET) * 100);
This could overflow, but only so many years into the future that it's
beyond our lifetime, so I don't mind leaving it as is.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-03-08 20:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 16:56 [Qemu-devel] [PATCH 0/2 v2] Add Windows support for time resync by qemu-ga Lei Li
2013-03-08 16:56 ` [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time Lei Li
2013-03-08 20:12 ` Eric Blake [this message]
2013-03-08 16:56 ` [Qemu-devel] [PATCH 2/2] qga: add windows implementation for guest-set-time Lei Li
2013-03-08 20:11 ` Eric Blake
-- strict thread matches above, loose matches on Subject: below --
2013-03-15 9:29 [Qemu-devel] [PATCH 0/2 v7] Add Windows support for time resync by qemu-ga Lei Li
2013-03-15 9:29 ` [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time Lei Li
2013-03-14 15:05 [Qemu-devel] [PATCH 0/2 v6] Add Windows support for time resync by qemu-ga Lei Li
2013-03-14 15:05 ` [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time Lei Li
2013-03-14 21:36 ` mdroth
2013-03-14 7:07 [Qemu-devel] [PATCH 0/2 v5] Add Windows support for time resync by qemu-ga Lei Li
2013-03-14 7:07 ` [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time Lei Li
2013-03-14 12:32 ` mdroth
2013-03-14 13:05 ` Lei Li
2013-03-13 10:10 [Qemu-devel] [PATCH 0/2 v4] Add Windows support for time resync by qemu-ga lilei
2013-03-13 10:10 ` [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time lilei
2013-03-13 20:07 ` mdroth
2013-03-13 20:21 ` mdroth
2013-03-14 6:19 ` Lei Li
2013-03-12 9:08 [Qemu-devel] [PATCH 0/2 v3] Add Windows support for time resync by qemu-ga Lei Li
2013-03-12 9:08 ` [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time Lei Li
2013-03-06 13:45 [Qemu-devel] [PATCH 0/2] Add Windows support for time resync by qemu-ga Lei Li
2013-03-06 13:45 ` [Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time Lei Li
2013-03-06 15:31 ` Eric Blake
2013-03-07 7:54 ` Lei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513A462F.3030606@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=lilei@linux.vnet.ibm.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).