From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UE3ot-0006fN-2U for qemu-devel@nongnu.org; Fri, 08 Mar 2013 15:23:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UE3om-0005kI-DS for qemu-devel@nongnu.org; Fri, 08 Mar 2013 15:23:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UE3om-0005k8-5N for qemu-devel@nongnu.org; Fri, 08 Mar 2013 15:23:04 -0500 Message-ID: <513A48A3.40102@redhat.com> Date: Fri, 08 Mar 2013 13:22:59 -0700 From: Eric Blake MIME-Version: 1.0 References: <1362636445-7188-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1362636445-7188-3-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1362636445-7188-3-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2OUXNNTFCAQJICKVTRXQN" Subject: Re: [Qemu-devel] [PATCH V8 02/20] build: add block/qapi.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2OUXNNTFCAQJICKVTRXQN Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/06/2013 11:07 PM, Wenchao Xia wrote: > This file will have qmp related functions for block. To avoid conflic= t and > tip better, macro in header file is BLOCK_QAPI_H instead of QAPI_H. >=20 > Signed-off-by: Wenchao Xia > --- > --- /dev/null > +++ b/include/block/qapi.h > @@ -0,0 +1,4 @@ > +#ifndef BLOCK_QAPI_H Again, introducing a new file without a copyright notice is a no-no. Why are you adding stub files in two separate patches? If you're going to bother with stub files, then add all of them in one commit. But my preference would be to add one file at a time, but with contents instead of being a stub (for example, merge patch 1 and 3, and merge patch 2 and 6). It just feels like you have subdivided this series too far. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2OUXNNTFCAQJICKVTRXQN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJROkijAAoJEKeha0olJ0NqvPAIAIqgh+kqDR0D5Za10XJ4cwaL FNGrHxlRikJ/YNIaRl9RNUSLdXrbbt5/NKcbH3ZFpHiWZaWnTvLY1tM/xnL063wH spSrPmzNJToKyCtNMowdZuW+/HQFmVrZObRqrliCSnMsUkgb/yARBJkGI4SicXr/ lsmZcdFFKDzbucQFfYELiod4saLh4i2GqePan8Vkr32ycjfvoTIBPoI9PmY3+J4r w5n1D50flNbQmSrg5lJeepxuL9MQ4JeahRqHfAHBJqP7hND7Aarm7mi0HAm4OBsw PD8Sk1PuuAYVXI4MoU0iE0kLBYJr2T413bkluUsqgDjNifMmuW1Ybt3YNNuX8Oc= =++JN -----END PGP SIGNATURE----- ------enig2OUXNNTFCAQJICKVTRXQN--