From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UE3zl-0007GT-P8 for qemu-devel@nongnu.org; Fri, 08 Mar 2013 15:34:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UE3zb-0000nm-TJ for qemu-devel@nongnu.org; Fri, 08 Mar 2013 15:34:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36481) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UE3zb-0000nW-Kj for qemu-devel@nongnu.org; Fri, 08 Mar 2013 15:34:15 -0500 Message-ID: <513A4B42.6000200@redhat.com> Date: Fri, 08 Mar 2013 13:34:10 -0700 From: Eric Blake MIME-Version: 1.0 References: <1362636445-7188-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1362636445-7188-6-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1362636445-7188-6-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2IPMXHCMJAEPDAJFXRAOV" Subject: Re: [Qemu-devel] [PATCH V8 05/20] qemu-img: remove unused parameter in collect_image_info() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2IPMXHCMJAEPDAJFXRAOV Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/06/2013 11:07 PM, Wenchao Xia wrote: > Parameter *fmt was not used, so remove it. >=20 > Reviewed-by: Eric Blake >=20 > Signed-off-by: Wenchao Xia Typically, these annotations should be kept in chronological order. That is, the first line should always be a Signed-off-by (you have to write a patch before anyone else can add their Reviewed-by). Also, we tend to avoid blank lines in the attribution section. So, the preferred way to write this would be: Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake But that's cosmetic, and my review still stands. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2IPMXHCMJAEPDAJFXRAOV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJROktDAAoJEKeha0olJ0NqPrsH/RU6aCTipZ54uAP2mxZUjNWW DsmNm8xPWj8y6hWvIQXyuZHzIQUrs/dvmxzS07GrRdf1aSV0wMLa4Isbz6r7J7Lu pANxtn2s5WqwgUwqqLJ71j0im1q1hz6f8mIkQh8gUC9lHCVuwq4Uy+Ynuos3s9DD shK7nWTuCd4p1ugotcIezBLymLwQa/PaotAZlQyqiz9FXalYP7rs1sPeeU0XYazK sQKaxzxKorMOAW/iEk1LCGobzjw8ovxtZ1EbuVpNDBuLyrvjZxUCQNuEhouID5qy FdDBtVDXWcxVCmkarqrJ2k9qL2sELCOwEIIJ/gIOcT50R49hEbjvskOdL2VNpQU= =iWLv -----END PGP SIGNATURE----- ------enig2IPMXHCMJAEPDAJFXRAOV--