From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49724) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEAyv-0006qB-BA for qemu-devel@nongnu.org; Fri, 08 Mar 2013 23:02:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UEAyq-0001Xn-Ir for qemu-devel@nongnu.org; Fri, 08 Mar 2013 23:02:01 -0500 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:39597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEAyq-0001XF-1K for qemu-devel@nongnu.org; Fri, 08 Mar 2013 23:01:56 -0500 Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 9 Mar 2013 13:51:54 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 913CE357804A for ; Sat, 9 Mar 2013 15:01:46 +1100 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r293mv3b56492060 for ; Sat, 9 Mar 2013 14:48:57 +1100 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2941jO5023126 for ; Sat, 9 Mar 2013 15:01:45 +1100 Message-ID: <513AB3E5.8070503@linux.vnet.ibm.com> Date: Sat, 09 Mar 2013 12:00:37 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1362636445-7188-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1362636445-7188-2-git-send-email-xiawenc@linux.vnet.ibm.com> <513A478C.6000202@redhat.com> In-Reply-To: <513A478C.6000202@redhat.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V8 01/20] build: add block/snapshot.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com > On 03/06/2013 11:07 PM, Wenchao Xia wrote: >> This file will have internal snapshot related functions. >> >> Signed-off-by: Wenchao Xia >> --- > >> --- /dev/null >> +++ b/include/block/snapshot.h >> @@ -0,0 +1,4 @@ >> +#ifndef SNAPSHOT_H > > Introducing a new file without a copyright notice is a no-no. > Copy right is notice in snapshot.c, other header files seems no copy right declaration, what more should be added? -- Best Regards Wenchao Xia