From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com,
qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH V8 02/20] build: add block/qapi.c
Date: Sat, 09 Mar 2013 12:05:59 +0800 [thread overview]
Message-ID: <513AB527.9080001@linux.vnet.ibm.com> (raw)
In-Reply-To: <513A48A3.40102@redhat.com>
于 2013-3-9 4:22, Eric Blake 写道:
> On 03/06/2013 11:07 PM, Wenchao Xia wrote:
>> This file will have qmp related functions for block. To avoid conflict and
>> tip better, macro in header file is BLOCK_QAPI_H instead of QAPI_H.
>>
>> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
>> ---
>
>> --- /dev/null
>> +++ b/include/block/qapi.h
>> @@ -0,0 +1,4 @@
>> +#ifndef BLOCK_QAPI_H
>
> Again, introducing a new file without a copyright notice is a no-no.
>
> Why are you adding stub files in two separate patches? If you're going
> to bother with stub files, then add all of them in one commit. But my
> preference would be to add one file at a time, but with contents instead
> of being a stub (for example, merge patch 1 and 3, and merge patch 2 and
> 6). It just feels like you have subdivided this series too far.
>
Just to make it easy for review, one patch for one step. I am OK to
merge if you insist, but prefer not for that these stub brings no
trouble, to save effort.
--
Best Regards
Wenchao Xia
next prev parent reply other threads:[~2013-03-09 4:06 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 6:07 [Qemu-devel] [PATCH V8 00/20] qmp/hmp interfaces for internal snapshot info Wenchao Xia
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 01/20] build: add block/snapshot.c Wenchao Xia
2013-03-08 20:18 ` Eric Blake
2013-03-09 4:00 ` Wenchao Xia
2013-03-09 13:10 ` Eric Blake
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 02/20] build: add block/qapi.c Wenchao Xia
2013-03-08 20:22 ` Eric Blake
2013-03-09 4:05 ` Wenchao Xia [this message]
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 03/20] block: move bdrv_snapshot_find() to block/snapshot.c Wenchao Xia
2013-03-08 20:27 ` Eric Blake
2013-03-09 4:17 ` Wenchao Xia
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 04/20] block: distinguish id and name in bdrv_find_snapshot() Wenchao Xia
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 05/20] qemu-img: remove unused parameter in collect_image_info() Wenchao Xia
2013-03-08 20:34 ` Eric Blake
2013-03-09 4:18 ` Wenchao Xia
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 06/20] block: move collect_snapshots() and collect_image_info() to block/qapi.c Wenchao Xia
2013-03-08 22:04 ` Eric Blake
2013-03-09 4:20 ` Wenchao Xia
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 07/20] block: add snapshot info query function bdrv_query_snapshot_info_list() Wenchao Xia
2013-03-08 22:15 ` Eric Blake
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 08/20] block: add filter for vm snapshot in bdrv_query_snapshot_info_list() Wenchao Xia
2013-03-08 22:55 ` Eric Blake
2013-03-09 4:24 ` Wenchao Xia
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 09/20] block: add image info query function bdrv_query_image_info() Wenchao Xia
2013-03-08 23:08 ` Eric Blake
2013-03-09 4:26 ` Wenchao Xia
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 10/20] qmp: add interface query-snapshots Wenchao Xia
2013-03-08 23:30 ` Eric Blake
2013-03-09 4:28 ` Wenchao Xia
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 11/20] qmp: add interface query-images Wenchao Xia
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 12/20] hmp: add function hmp_info_snapshots() Wenchao Xia
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 13/20] hmp: switch snapshot info function to qmp based one Wenchao Xia
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 14/20] block: move dump_human_image_info() to block/qapi.c Wenchao Xia
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 15/20] block: dump to buffer for bdrv_image_info_dump() Wenchao Xia
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 16/20] hmp: add command info images Wenchao Xia
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 17/20] block: return bool for bdrv_can_snapshot() Wenchao Xia
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 18/20] block: move snapshot related functions to block/snapshot.c Wenchao Xia
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 19/20] block: move bdrv_snapshot_dump() to block/qapi.c Wenchao Xia
2013-03-07 6:07 ` [Qemu-devel] [PATCH V8 20/20] block: rename bdrv_query_info() to bdrv_query_block_info() Wenchao Xia
2013-03-07 7:36 ` [Qemu-devel] [PATCH V8 00/20] qmp/hmp interfaces for internal snapshot info Markus Armbruster
2013-03-11 1:24 ` Wenchao Xia
2013-03-11 8:34 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513AB527.9080001@linux.vnet.ibm.com \
--to=xiawenc@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).