From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEJXi-0002hZ-EY for qemu-devel@nongnu.org; Sat, 09 Mar 2013 08:10:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UEJXd-0003qZ-03 for qemu-devel@nongnu.org; Sat, 09 Mar 2013 08:10:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47625) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEJXc-0003q3-OE for qemu-devel@nongnu.org; Sat, 09 Mar 2013 08:10:24 -0500 Message-ID: <513B34BA.3080203@redhat.com> Date: Sat, 09 Mar 2013 06:10:18 -0700 From: Eric Blake MIME-Version: 1.0 References: <1362636445-7188-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1362636445-7188-2-git-send-email-xiawenc@linux.vnet.ibm.com> <513A478C.6000202@redhat.com> <513AB3E5.8070503@linux.vnet.ibm.com> In-Reply-To: <513AB3E5.8070503@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2EERRJVFCHPMQEAUOTTUB" Subject: Re: [Qemu-devel] [PATCH V8 01/20] build: add block/snapshot.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2EERRJVFCHPMQEAUOTTUB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/08/2013 09:00 PM, Wenchao Xia wrote: >=20 >> On 03/06/2013 11:07 PM, Wenchao Xia wrote: >>> This file will have internal snapshot related functions. >>> >>> Signed-off-by: Wenchao Xia >>> --- >> >>> --- /dev/null >>> +++ b/include/block/snapshot.h >>> @@ -0,0 +1,4 @@ >>> +#ifndef SNAPSHOT_H >> >> Introducing a new file without a copyright notice is a no-no. >> >=20 > Copy right is notice in snapshot.c, other header files seems > no copy right declaration, what more should be added? The copyright of the .c file should be copied to the .h file then. EVERY file needs a copyright, not just one of a pair of files. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2EERRJVFCHPMQEAUOTTUB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJROzS6AAoJEKeha0olJ0NqAl4H/RXxhVXY6XUS2MTSw3qmUF0s MKgV87xvXzDl5tCxYYWYwBBc5z8GJ4s6M5hPweZ9MgsgZxu8n79OfY4LIxyr4N+p nbTZy0dg647Gl8qjsIxmcl6uQSdEkOtW+8E45gPAXhuqaOKzraTu+S/jDS5JNuJc CtbGPmBg7a3LF5aCxlVbs5VZ7LJyBtXeQp6swrmZETriO7jKOSPLUxiYaKG0w49y Iz7ezUuP5Wa7CN6iOVu8QfqkMsPhFnv+72t0aYRYjukF5lh9G0zvWGbLA3GrcWmv GldGjaFVI15Df5U/0qw3O8FxQ+4bHvnZqqZK3s+Kf06RvKTwaifWIbyiLEQgMjU= =Vz/g -----END PGP SIGNATURE----- ------enig2EERRJVFCHPMQEAUOTTUB--