qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mitsyanko <i.mitsyanko@gmail.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: amit.shah@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-char: fix win32 build
Date: Sun, 10 Mar 2013 17:50:22 +0400	[thread overview]
Message-ID: <513C8F9E.1070907@gmail.com> (raw)
In-Reply-To: <0ba5565b1ed44380c57d4a5fab86e9549f581ebf.1362822910.git.blauwirbel@gmail.com>

On 09.03.2013 13:56, Blue Swirl wrote:
> 96c6384776d631839a9c8fe02bf135f9ba22586c did not adjust
> Win32 #ifdeffery properly, breaking build in later commits. Fix.
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
>   qemu-char.c |    6 ++++--
>   1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index b82d643..04aa589 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -535,8 +535,6 @@ int send_all(int fd, const void *_buf, int len1)
>   }
>   #endif /* !_WIN32 */
>
> -#ifndef _WIN32
> -
>   typedef struct IOWatchPoll
>   {
>       GSource *src;
> @@ -634,6 +632,7 @@ static guint io_add_watch_poll(GIOChannel *channel,
>       return tag;
>   }
>
> +#ifndef _WIN32
>   static GIOChannel *io_channel_from_fd(int fd)
>   {
>       GIOChannel *chan;
> @@ -649,6 +648,7 @@ static GIOChannel *io_channel_from_fd(int fd)
>
>       return chan;
>   }
> +#endif
>
>   static GIOChannel *io_channel_from_socket(int fd)
>   {
> @@ -699,6 +699,8 @@ static int io_channel_send_all(GIOChannel *fd, const void *_buf, int len1)
>       return len1 - len;
>   }
>
> +#ifndef _WIN32
> +
>   typedef struct FDCharDriver {
>       CharDriverState *chr;
>       GIOChannel *fd_in, *fd_out;
>

This patch fixes build for me.

Tested-by: Igor Mitsyanko <i.mitsyanko@gmail.com>

  reply	other threads:[~2013-03-10 13:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-09  9:56 [Qemu-devel] [PATCH 1/2] baum: fix build Blue Swirl
2013-03-09  9:56 ` [Qemu-devel] [PATCH 2/2] qemu-char: fix win32 build Blue Swirl
2013-03-10 13:50   ` Igor Mitsyanko [this message]
2013-03-10 21:03 ` [Qemu-devel] [PATCH 1/2] baum: fix build Stefan Weil
2013-03-12  2:02 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513C8F9E.1070907@gmail.com \
    --to=i.mitsyanko@gmail.com \
    --cc=aliguori@us.ibm.com \
    --cc=amit.shah@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).