From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UElKj-0003Hh-VS for qemu-devel@nongnu.org; Sun, 10 Mar 2013 14:51:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UElKg-0008Dj-K4 for qemu-devel@nongnu.org; Sun, 10 Mar 2013 14:50:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UElKg-0008Da-CJ for qemu-devel@nongnu.org; Sun, 10 Mar 2013 14:50:54 -0400 Message-ID: <513CD688.1060400@redhat.com> Date: Sun, 10 Mar 2013 19:52:56 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <513C7C61.8020102@wiesinger.com> <513CA3AB.1030608@wiesinger.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] Compile error on FC17 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Gerhard Wiesinger , "qemu-devel@nongnu.org" On 03/10/13 18:04, Peter Maydell wrote: > On 10 March 2013 15:15, Gerhard Wiesinger wrote: >> Tried make clean and make distclean already before I reported the issu= e. >> >> If I'm suppressing "warning as errors" I'm still getting errors: >> >> hw/usb/hcd-xhci.c: In function =E2=80=98xhci_set_ep_dequeue=E2=80=99: >> hw/usb/hcd-xhci.c:1471:5: error: too many arguments to function >> =E2=80=98trace_usb_xhci_ep_set_dequeue=E2=80=99 >> In file included from hw/usb/hcd-xhci.c:27:0: >> ./trace.h:1052:58: note: declared here >=20 >> BTW: Isn't a new issue (around 2 month) but was very busy. >=20 > Oh, right. Tracing functions moved from trace.h to the files > in the trace/ subdirectory. This means that if you didn't do > a make clean or distclean before doing the git update then > the new makefile knows nothing about the old trace.h file and > so won't delete it, but the compiler may still pull it in anyhow. > However this happened a long time back which is why I didn't > mention it as a possibility (it was discussed on the list at > the time as a number of people including me ran into it). > If you remove all the files: > trace.c trace.h trace.c-timestamp trace.h-timestamp > this should resolve the problem. >=20 > This is an example of a longstanding problem we have, where > the makefile's dependency rules aren't able to cope with > changes to the project source file structure, and so clean, > distclean and incremental build sometimes breaks across a > git update. I think this is pretty intractable as a problem > to solve; you can mitigate it by doing all your builds in > a build directory rather than in the source tree itself, > since then you can always just delete the whole build tree > to get a definite from-scratch build. There's also $ git reset --hard $ git clean -fdx $ ./configure ... Laszlo