From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEzZx-00025U-14 for qemu-devel@nongnu.org; Mon, 11 Mar 2013 06:03:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UEzZq-0008ET-RP for qemu-devel@nongnu.org; Mon, 11 Mar 2013 06:03:36 -0400 Received: from ssl.dlhnet.de ([91.198.192.8]:34624 helo=ssl.dlh.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEzZq-0008E7-MA for qemu-devel@nongnu.org; Mon, 11 Mar 2013 06:03:30 -0400 Message-ID: <513DABF0.7010906@dlhnet.de> Date: Mon, 11 Mar 2013 11:03:28 +0100 From: Peter Lieven MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH 1/3] Revert "block: complete all IOs before .bdrv_truncate" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org" Cc: Kevin Wolf , Paolo Bonzini , Jeff Cody , Anthony Liguori brdv_truncate() is also called from readv/writev commands on self- growing file based storage. this will result in requests waiting for theirselves to complete. This reverts commit 9a665b2b8640e464f0a778216fc2dca8d02acf33. --- block.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/block.c b/block.c index 124a9eb..60c246a 100644 --- a/block.c +++ b/block.c @@ -2449,10 +2449,6 @@ int bdrv_truncate(BlockDriverState *bs, int64_t offset) return -EACCES; if (bdrv_in_use(bs)) return -EBUSY; - - /* There better not be any in-flight IOs when we truncate the device. */ - bdrv_drain_all(); - ret = drv->bdrv_truncate(bs, offset); if (ret == 0) { ret = refresh_total_sectors(bs, offset >> BDRV_SECTOR_BITS); -- 1.7.9.5