From: Peter Lieven <pl@dlhnet.de>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, Jeff Cody <jcody@redhat.com>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight
Date: Mon, 11 Mar 2013 11:05:15 +0100 [thread overview]
Message-ID: <513DAC5B.5000607@dlhnet.de> (raw)
ensure that there are no pending I/Os before calling
the sync readcapacity commands. the block_resize monitor
command will also flush all I/O, but double check in
case iscsi_truncate() is called from elsewhere in the
future.
Signed-off-by: Peter Lieven <pl@kamp.de>
---
block/iscsi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index 3d52921..de20d53 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1167,6 +1167,10 @@ static int iscsi_truncate(BlockDriverState *bs, int64_t offset)
return -ENOTSUP;
}
+ /* ensure all async requests are completed before executing
+ * a sync readcapacity */
+ bdrv_drain_all();
+
if ((ret = iscsi_readcapacity_sync(iscsilun)) != 0) {
return ret;
}
--
1.7.9.5
next reply other threads:[~2013-03-11 10:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 10:05 Peter Lieven [this message]
2013-03-11 10:16 ` [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight Paolo Bonzini
2013-03-11 10:19 ` Peter Lieven
2013-03-11 11:44 ` Paolo Bonzini
2013-03-11 11:52 ` Peter Lieven
2013-03-11 13:00 ` Paolo Bonzini
2013-03-13 9:31 ` Kevin Wolf
2013-03-13 10:15 ` Paolo Bonzini
2013-03-19 7:29 ` Peter Lieven
2013-03-19 9:44 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513DAC5B.5000607@dlhnet.de \
--to=pl@dlhnet.de \
--cc=anthony@codemonkey.ws \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).