From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40785)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UF25t-0000jI-R0
	for qemu-devel@nongnu.org; Mon, 11 Mar 2013 08:44:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UF25r-0007bm-Gi
	for qemu-devel@nongnu.org; Mon, 11 Mar 2013 08:44:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57839)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UF25r-0007be-7U
	for qemu-devel@nongnu.org; Mon, 11 Mar 2013 08:44:43 -0400
Message-ID: <513DD1B5.7040906@redhat.com>
Date: Mon, 11 Mar 2013 13:44:37 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1363000640-13398-1-git-send-email-pbonzini@redhat.com>
	<CAFEAcA8MBOV897+oXWC0ZkwFSZKxT4ujyrjbKqZOfNVBhBfpBg@mail.gmail.com>
	<513DC5FA.30205@redhat.com>
	<CAFEAcA-J2z3wVSbSLgeT9DOQRvarDWkuRrOLWaFWdMi+KwjE5A@mail.gmail.com>
In-Reply-To: <CAFEAcA-J2z3wVSbSLgeT9DOQRvarDWkuRrOLWaFWdMi+KwjE5A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] Proposal for hw/ split
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Crosthwaite <peter.crosthwaite@petalogix.com>, qemu-devel@nongnu.org, afaerber@suse.de, agraf@suse.de

Il 11/03/2013 13:39, Peter Maydell ha scritto:
> On 11 March 2013 11:54, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Il 11/03/2013 12:31, Peter Maydell ha scritto:
>>> On 11 March 2013 11:17, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>>> hw/arm11mpcore.c                             hw/arm/arm11mpcore.c
>>>
>>> Two devices but I can split them if you insist.
>>
>> These are little more than SoC containers, aren't they?
> 
> They're container devices, yes. But why should container devices
> go under hw/$ARCH ?

Because they don't really implement any logic, ideally a board should be
a little more than a bunch of container devices.  And boards go under
hw/$ARCH.

>>>> hw/kvm/arm_gic.c                             hw/arm/kvm/arm_gic.c
>>>
>>> If we're going to move kvm specific devices out of hw/kvm I'd
>>> rather they just went in hw/. It's an implementation detail that
>>> a device's back end is KVM specific, so kvm_arm_gic.c should go
>>> alongside arm_gic.c.
>>
>> I moved them to hw/ARCH because they really depend on the host kernel.
> 
> That's backwards. To the extent hw/ARCH is anything, it's stuff
> specific to guest ARCH, not host ARCH.

For KVM guest == host, so you cannot reuse them for any other
architectures.  But if there's disagreement, leaving them in hw/kvm/ is
the best thing to do.

Paolo