From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UF2LW-0005uM-QM for qemu-devel@nongnu.org; Mon, 11 Mar 2013 09:00:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UF2LR-0005PV-Tb for qemu-devel@nongnu.org; Mon, 11 Mar 2013 09:00:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31719) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UF2LR-0005PJ-Lz for qemu-devel@nongnu.org; Mon, 11 Mar 2013 09:00:49 -0400 Message-ID: <513DD577.103@redhat.com> Date: Mon, 11 Mar 2013 14:00:39 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <513DAC5B.5000607@dlhnet.de> <513DAF15.4030000@redhat.com> <74DFB48B-A0B9-49CF-AD04-477BFA275845@dlhnet.de> <513DC3AF.8030104@redhat.com> <513DC561.7080802@dlhnet.de> In-Reply-To: <513DC561.7080802@dlhnet.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: Kevin Wolf , Jeff Cody , "qemu-devel@nongnu.org" , Anthony Liguori Il 11/03/2013 12:52, Peter Lieven ha scritto: >> >> For example, qcow1 (and VHDX) will already call it, but that's a bug and >> should be fixed otherwise. Your patch will just cause an assertion >> failure. > > In which case can qcow1 (and VHDX) be used in conjunction with an iSCSI > Target? No. It is a bug that they are accepted, but we have time to fix it before 1.5. Paolo > Would it be ok for you to assert if iscsi_truncate() is called when there > are aio's in flight? How can this be checked? > > I just want to make sure that nothing nasty happens in that case (such as > nested event loops).