From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UF5o8-0006UF-V4 for qemu-devel@nongnu.org; Mon, 11 Mar 2013 12:42:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UF5gr-0008Nx-Ju for qemu-devel@nongnu.org; Mon, 11 Mar 2013 12:35:18 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:56213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UF5gr-0008NU-C7 for qemu-devel@nongnu.org; Mon, 11 Mar 2013 12:35:09 -0400 Received: from /spool/local by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 11 Mar 2013 10:35:07 -0600 Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id AE55B3E40042 for ; Mon, 11 Mar 2013 10:34:50 -0600 (MDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2BGYmio057664 for ; Mon, 11 Mar 2013 10:34:51 -0600 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2BGbNqE030292 for ; Mon, 11 Mar 2013 10:37:23 -0600 Message-ID: <513E07A4.40104@linux.vnet.ibm.com> Date: Mon, 11 Mar 2013 12:34:44 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1362976414-21396-1-git-send-email-mrhines@us.ibm.com> <1362976414-21396-10-git-send-email-mrhines@us.ibm.com> <513DE526.80108@redhat.com> In-Reply-To: <513DE526.80108@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v3: 09/10] Move RAMBlock to cpu-common.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, mst@redhat.com, michael.r.hines.mrhines@linux.vnet.ibm.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com Understood......will take care of both of these. On 03/11/2013 10:07 AM, Paolo Bonzini wrote: > Only used in qemu_rdma_init_ram_blocks. Can you add instead an API > like qemu_ram_foreach_block( void (*fn)(void *host_addr, ram_addr_t > offset, ram_addr_t length, void *opaque), void *opaque) ? BTW, please > avoid arbitrary limits like RDMA_MAX_RAM_BLOCKS. Can you use a list > (see qemu-queue.h; it is the same as the BSD queue.h) instead of > current_index? Paolo