Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1732 bytes --]

On 03/11/2013 05:23 AM, Wenchao Xia wrote:
>   This patch adds block/snapshot.c and then moves the function
> there. It also fixes small code style errors reported by check script.
> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
>  block/Makefile.objs      |    1 +
>  block/snapshot.c         |   37 +++++++++++++++++++++++++++++++++++++
>  include/block/snapshot.h |   26 ++++++++++++++++++++++++++
>  savevm.c                 |   23 +----------------------
>  4 files changed, 65 insertions(+), 22 deletions(-)
>  create mode 100644 block/snapshot.c
>  create mode 100644 include/block/snapshot.h

> +++ b/block/snapshot.c
> @@ -0,0 +1,37 @@
> +/*
> + * Snapshot related functions.
> + *
> + * Copyright IBM, Corp. 2013

Technically, since you are moving code from savevm.c, you should also
preserve the copyright on that moved code:

 * Copyright (c) 2003-2008 Fabrice Bellard

> + *
> + * Authors:
> + *  Wenchao Xia   <xiawenc@linux.vnet.ibm.com>
> + *
> + * This work is licensed under the terms of the GNU LGPL, version 2 or later.

Furthermore, the code you are moving was under BSD license, so by moving
the code, you have changed its license to something more restrictive.
Personally, I like LGPL better than BSD, but as I'm not the copyright
holder of the original code, and neither are you, I'm not sure that
either of us is qualified to make that change.  Therefore, I'm unwilling
to add my Reviewed-by, even though the code motion itself is correct,
without a maintainer chiming in on whether your licensing is appropriate
or needs an adjustment.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]