From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54256) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UF6rB-0000GK-Mr for qemu-devel@nongnu.org; Mon, 11 Mar 2013 13:50:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UF6r5-0001zn-03 for qemu-devel@nongnu.org; Mon, 11 Mar 2013 13:49:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UF6r4-0001yQ-Ok for qemu-devel@nongnu.org; Mon, 11 Mar 2013 13:49:46 -0400 Message-ID: <513E1934.4030908@redhat.com> Date: Mon, 11 Mar 2013 11:49:40 -0600 From: Eric Blake MIME-Version: 1.0 References: <1363000996-13221-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1363000996-13221-2-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1363000996-13221-2-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2DPXDALXGVSBFDGHLJOKP" Subject: Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2DPXDALXGVSBFDGHLJOKP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/11/2013 05:23 AM, Wenchao Xia wrote: > This patch adds block/snapshot.c and then moves the function > there. It also fixes small code style errors reported by check script. >=20 > Signed-off-by: Wenchao Xia > --- > block/Makefile.objs | 1 + > block/snapshot.c | 37 +++++++++++++++++++++++++++++++++++++ > include/block/snapshot.h | 26 ++++++++++++++++++++++++++ > savevm.c | 23 +---------------------- > 4 files changed, 65 insertions(+), 22 deletions(-) > create mode 100644 block/snapshot.c > create mode 100644 include/block/snapshot.h > +++ b/block/snapshot.c > @@ -0,0 +1,37 @@ > +/* > + * Snapshot related functions. > + * > + * Copyright IBM, Corp. 2013 Technically, since you are moving code from savevm.c, you should also preserve the copyright on that moved code: * Copyright (c) 2003-2008 Fabrice Bellard > + * > + * Authors: > + * Wenchao Xia > + * > + * This work is licensed under the terms of the GNU LGPL, version 2 or= later. Furthermore, the code you are moving was under BSD license, so by moving the code, you have changed its license to something more restrictive. Personally, I like LGPL better than BSD, but as I'm not the copyright holder of the original code, and neither are you, I'm not sure that either of us is qualified to make that change. Therefore, I'm unwilling to add my Reviewed-by, even though the code motion itself is correct, without a maintainer chiming in on whether your licensing is appropriate or needs an adjustment. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2DPXDALXGVSBFDGHLJOKP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRPhk0AAoJEKeha0olJ0NqsTsH/2XJrZ5q72MN7IYNd55jLY/5 LNWBqN6DnPtQgNzIFjJvm2HB+D4h7vF8HjyfipwDgwFv8C/CRyebyXuyiELkY6jx c5CG/ViRP+xtc1iW0H7OyfaC9D7njgqQFbxPxziCRF98yBRkcmcGom9ZDtYuRrCt SoDb+lvBRsc4qHOZpbAx56q6vJzA64FQClj4TJT4zVNC0Kgx/sRGVYG/1Aw9SC1G klTK0CWqIB3azpL/gNxAG+RDXXgjyP3ggFT56cCH+xqcsqmjNvpa0VNZtkl4CFrm TXToQs0hRu0WW6ohExP59UpiPWNKylcNexfYBhAaW1g+g9icgG88w1ZuvomS2Fg= =JE7J -----END PGP SIGNATURE----- ------enig2DPXDALXGVSBFDGHLJOKP--