From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFFbC-0002CA-KP for qemu-devel@nongnu.org; Mon, 11 Mar 2013 23:10:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFFbA-0001Qb-Cn for qemu-devel@nongnu.org; Mon, 11 Mar 2013 23:09:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55917) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFFbA-0001QI-2W for qemu-devel@nongnu.org; Mon, 11 Mar 2013 23:09:56 -0400 Message-ID: <513E9C7B.8040906@redhat.com> Date: Tue, 12 Mar 2013 11:09:47 +0800 From: Jason Wang MIME-Version: 1.0 References: <1362644631-23113-1-git-send-email-jasowang@redhat.com> <1362644631-23113-2-git-send-email-jasowang@redhat.com> <5138B42D.3030800@redhat.com> <20130311143103.GA867904@orkuz.home> In-Reply-To: <20130311143103.GA867904@orkuz.home> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V7 1/5] runstate: introduce prelaunch-migrate state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jiri Denemark Cc: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, pbonzini@redhat.com On 03/11/2013 10:31 PM, Jiri Denemark wrote: > On Thu, Mar 07, 2013 at 08:37:17 -0700, Eric Blake wrote: >> On 03/07/2013 01:23 AM, Jason Wang wrote: >>> Sometimes, we need track the state when guest is just about to start after >>> migration. There's not a accurate state available which do this accurately >>> (consider qemu may started with -S in destination). >> s/may/may be/ >> >> and yes, libvirt _always_ starts qemu with -S in the destination. >> >>> So this patch introduces a new state prelaunch-migrate which just tracks this >>> state, it covers the case both w/ and w/o -S in destination. The first user of >>> this is the support of doing announce by guest. >>> >>> Signed-off-by: Jason Wang >>> --- >>> migration.c | 3 +-- >>> qapi-schema.json | 5 ++++- >>> vl.c | 4 +++- >>> 3 files changed, 8 insertions(+), 4 deletions(-) >> I'm not sure if this patch will have any negative effects on existing >> libvirt migration or state reporting; adding Jirka to cc. > I don't see any issues this patch could cause to libvirt. The only place > where we ask qemu for its current state is when we reconnect to existing > qemu processes after libvirtd restart. And the only thing we care about > is whether the guest is running or not. We use our own state information > to detect if we were migrating or not. > > Jirka > Thanks for the checking. Since Michael prefers a device specific method instead of introducing a new runstate, I plan to use post load and vm state change handler instead of this new runstate in next version.