From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFHMe-0003F0-Oj for qemu-devel@nongnu.org; Tue, 12 Mar 2013 01:03:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFHMd-0001dL-Ca for qemu-devel@nongnu.org; Tue, 12 Mar 2013 01:03:04 -0400 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:55844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFHMc-0001bd-S7 for qemu-devel@nongnu.org; Tue, 12 Mar 2013 01:03:03 -0400 Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 12 Mar 2013 10:29:57 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id C29E83940053 for ; Tue, 12 Mar 2013 10:32:51 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2C52mGb16646234 for ; Tue, 12 Mar 2013 10:32:48 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2C52njb026711 for ; Tue, 12 Mar 2013 16:02:49 +1100 Message-ID: <513EB6B3.9050609@linux.vnet.ibm.com> Date: Tue, 12 Mar 2013 13:01:39 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1363000996-13221-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1363000996-13221-2-git-send-email-xiawenc@linux.vnet.ibm.com> <513E1934.4030908@redhat.com> In-Reply-To: <513E1934.4030908@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, armbru@redhat.com 于 2013-3-12 1:49, Eric Blake 写道: > On 03/11/2013 05:23 AM, Wenchao Xia wrote: >> This patch adds block/snapshot.c and then moves the function >> there. It also fixes small code style errors reported by check script. >> >> Signed-off-by: Wenchao Xia >> --- >> block/Makefile.objs | 1 + >> block/snapshot.c | 37 +++++++++++++++++++++++++++++++++++++ >> include/block/snapshot.h | 26 ++++++++++++++++++++++++++ >> savevm.c | 23 +---------------------- >> 4 files changed, 65 insertions(+), 22 deletions(-) >> create mode 100644 block/snapshot.c >> create mode 100644 include/block/snapshot.h > >> +++ b/block/snapshot.c >> @@ -0,0 +1,37 @@ >> +/* >> + * Snapshot related functions. >> + * >> + * Copyright IBM, Corp. 2013 > > Technically, since you are moving code from savevm.c, you should also > preserve the copyright on that moved code: > > * Copyright (c) 2003-2008 Fabrice Bellard > >> + * >> + * Authors: >> + * Wenchao Xia >> + * >> + * This work is licensed under the terms of the GNU LGPL, version 2 or later. > > Furthermore, the code you are moving was under BSD license, so by moving > the code, you have changed its license to something more restrictive. > Personally, I like LGPL better than BSD, but as I'm not the copyright > holder of the original code, and neither are you, I'm not sure that > either of us is qualified to make that change. Therefore, I'm unwilling > to add my Reviewed-by, even though the code motion itself is correct, > without a maintainer chiming in on whether your licensing is appropriate > or needs an adjustment. > Oops, Since it belongs to block layer I hope it can be LGPL2. Do you know how to contact Fabrice Bellard to ask for a change? -- Best Regards Wenchao Xia