Re: [Qemu-devel] [PATCH 09/18] hw: include hw header files with full paths

["KONRAD Frédéric" <fred.konrad@greensocs.com>]

On 01/03/2013 14:33, Paolo Bonzini wrote:
> Done with this script:
>
> cd hw
> for i in `find . -name '*.h' | sed 's/^..//'`; do
>    echo '\,^#.*include.*["<]'$i'[">], s,'$i',hw/&,'
> done | sed -i -f - `find . -type f`
>
> This is so that paths remain valid as files are moved.
>
> Instead, files in hw/dataplane are referenced with the relative path.
> We know they are not going to move to include/, and they are the only
> include files that are in subdirectories _and_ move.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Hi Paolo,
>   
> diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
> index 34913ee..248a966 100644
> --- a/hw/virtio-blk.c
> +++ b/hw/virtio-blk.c
> @@ -16,11 +16,11 @@
>   #include "trace.h"
>   #include "hw/block-common.h"
>   #include "sysemu/blockdev.h"
> -#include "virtio-blk.h"
> +#include "hw/virtio-blk.h"
>   #ifdef CONFIG_VIRTIO_BLK_DATA_PLANE
> -#include "hw/dataplane/virtio-blk.h"
> +#include "dataplane/virtio-blk.h"
Is that normal? ^^
Or I missed something?
I though you include hw header with full paths?

Thanks,

Fred