From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51987)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UFKUE-00068P-P6
	for qemu-devel@nongnu.org; Tue, 12 Mar 2013 04:23:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UFKUC-00065p-UW
	for qemu-devel@nongnu.org; Tue, 12 Mar 2013 04:23:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20523)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UFKUC-00065Z-Ki
	for qemu-devel@nongnu.org; Tue, 12 Mar 2013 04:23:04 -0400
Message-ID: <513EE5E2.8050207@redhat.com>
Date: Tue, 12 Mar 2013 09:22:58 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1362144829-26979-1-git-send-email-pbonzini@redhat.com>
	<1362144829-26979-10-git-send-email-pbonzini@redhat.com>
	<513EE519.7000209@greensocs.com>
In-Reply-To: <513EE519.7000209@greensocs.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 09/18] hw: include hw header files with
 full paths
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?KONRAD_Fr=E9d=E9ric?= <fred.konrad@greensocs.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, afaerber@suse.de

Il 12/03/2013 09:19, KONRAD Fr=E9d=E9ric ha scritto:
> On 01/03/2013 14:33, Paolo Bonzini wrote:
>> Done with this script:
>>
>> cd hw
>> for i in `find . -name '*.h' | sed 's/^..//'`; do
>>    echo '\,^#.*include.*["<]'$i'[">], s,'$i',hw/&,'
>> done | sed -i -f - `find . -type f`
>>
>> This is so that paths remain valid as files are moved.
>>
>> Instead, files in hw/dataplane are referenced with the relative path.
>> We know they are not going to move to include/, and they are the only
>> include files that are in subdirectories _and_ move.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Hi Paolo,
>>   diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
>> index 34913ee..248a966 100644
>> --- a/hw/virtio-blk.c
>> +++ b/hw/virtio-blk.c
>> @@ -16,11 +16,11 @@
>>   #include "trace.h"
>>   #include "hw/block-common.h"
>>   #include "sysemu/blockdev.h"
>> -#include "virtio-blk.h"
>> +#include "hw/virtio-blk.h"
>>   #ifdef CONFIG_VIRTIO_BLK_DATA_PLANE
>> -#include "hw/dataplane/virtio-blk.h"
>> +#include "dataplane/virtio-blk.h"
> Is that normal? ^^
> Or I missed something?
> I though you include hw header with full paths?

See the commit message: "files in hw/dataplane are referenced with the
relative path. We know they are not going to move to include/, and they
are the only include files that are in subdirectories _and_ move".

Paolo